New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for adding a family to an image. #704

Closed
wants to merge 1 commit into
base: trunk
from

Conversation

Projects
None yet
2 participants
@illfelder
Contributor

illfelder commented Feb 12, 2016

The feature is currently in beta, and will allow users to reference the latest, non-deprecated, image for a given family via the API.

@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney

tonybaloney Feb 12, 2016

Contributor

Hi. Changes look good. So the feature in GCE is beta? Any idea when it will be completed? @erjohnso

Contributor

tonybaloney commented Feb 12, 2016

Hi. Changes look good. So the feature in GCE is beta? Any idea when it will be completed? @erjohnso

@illfelder

This comment has been minimized.

Show comment
Hide comment
@illfelder

illfelder Feb 12, 2016

Contributor

The feature is already in beta, but our plan for releasing it into the v1 API includes making third party client updates. You can view the documentation for a new "getFromFamily" API endpoint here: https://cloud.google.com/compute/docs/reference/beta/images/getFromFamily

Image publishers need to create new images with the family property set before the feature will be generally useful. In order to begin the transition, we are making API client updates that enable using the feature during image creation.

Contributor

illfelder commented Feb 12, 2016

The feature is already in beta, but our plan for releasing it into the v1 API includes making third party client updates. You can view the documentation for a new "getFromFamily" API endpoint here: https://cloud.google.com/compute/docs/reference/beta/images/getFromFamily

Image publishers need to create new images with the family property set before the feature will be generally useful. In order to begin the transition, we are making API client updates that enable using the feature during image creation.

@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney

tonybaloney Feb 12, 2016

Contributor

Understood. Wouldn't want to introduce a chicken & egg then. Changes LGTM 👍

Contributor

tonybaloney commented Feb 12, 2016

Understood. Wouldn't want to introduce a chicken & egg then. Changes LGTM 👍

if isinstance(volume, StorageVolume):
image_data['sourceDisk'] = volume.extra['selfLink']
image_data['zone'] = volume.extra['zone'].name
elif isinstance(volume, str) and \
volume.startswith('https://') and volume.endswith('tar.gz'):
elif (isinstance(volume, str) and

This comment has been minimized.

@tonybaloney

tonybaloney Feb 14, 2016

Contributor

should make a todo here about unicode support wrt, Python 2/3

@tonybaloney

tonybaloney Feb 14, 2016

Contributor

should make a todo here about unicode support wrt, Python 2/3

@asfgit asfgit closed this in 41ff551 Feb 14, 2016

asfgit pushed a commit that referenced this pull request Feb 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment