Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed httplib_ssl socket exception handling. #714

Closed
wants to merge 1 commit into from
Closed

Fixed httplib_ssl socket exception handling. #714

wants to merge 1 commit into from

Conversation

crunk1
Copy link
Contributor

@crunk1 crunk1 commented Feb 26, 2016

@crunk1
Copy link
Contributor Author

crunk1 commented Feb 26, 2016

@erjohnso @Kami could you PTAL at this. We need to pull a fix in for this internally at Google.

@Kami
Copy link
Member

Kami commented Feb 27, 2016

Good catch, thanks.

I did at some test cases for this, but looks like I missed this edge case :( I will merge this into trunk and also add a test case for this.

Thanks again.

@asfgit asfgit closed this in b7fb13c Feb 27, 2016
@Kami
Copy link
Member

Kami commented Feb 27, 2016

Added a test case (f61f3cf) and merged patch into trunk.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants