DimesionData: Generic pagination, anti-affinity rules, create firewall expansion #726
Conversation
|
|
||
| rules = [] | ||
| for result in paged_result: | ||
| rules.extend(self._to_anti_affinity_rules(result)) |
There was a problem hiding this comment.
would probably be quicker to use list comprehension here
There was a problem hiding this comment.
I Think since our to methods are returning lists here themselves extend makes more sense than list comprehension. If you have a better way let me know because all of our functions will have the same type of style in them so we should get it right the first time.
|
changes look good. once tests are supporting I will test and merge. |
jadunham1
changed the title
| """ | ||
| def __init__(self, id, node_list): | ||
| self.id = id | ||
| self.node_list = node_list |
There was a problem hiding this comment.
Can you docstring what this does/type etc please.
There was a problem hiding this comment.
Whoops missed that one
|
Excellent changes, great to see some improvement in the tests as well. We'll need this in a few weeks when the 2.2 API comes out. Only 1 small change about docstring then we're good to merge |
|
thanks LGTM |
2 participants
Added:
ex_list_anti_affinity_rules
ex_create_anti_affinity_rule
ex_delete_anti_affinity_rule
generic pagination function
modified ex_create_firewall_rule to be able to place rules in a specific position relative to another rule
Tests for all new added features
Added some more coverage tests to ex_create_firewall rule
97% coverage in our compute driver now.