Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaces httplib.request with requests library #728

Merged
merged 32 commits into from Jan 9, 2017
Merged

Replaces httplib.request with requests library #728

merged 32 commits into from Jan 9, 2017

Conversation

tonybaloney
Copy link
Contributor

Todo:

  • map out dependencies for change
  • replace LibcloudHTTPConnection and LibcloudHTTPSconnection with requests powered connection classes
  • refactor out unneeded code from old libs, e.g. SSL validation
  • test

@tonybaloney
Move logging connection classes to another module -why don't people j…
cb0f499 
…ust use a logging proxy instead? so much easier!
@tonybaloney
Remove the double connect hack
649c70e
@tonybaloney
remove httplib wrapper and start on requests
b2f5b22
@tonybaloney
Add requests as a required installed package
c3fab31
@tonybaloney
Fix module ref for logging connection, fix indenting on logging conne…
96f69cf 
…ction imports
@tonybaloney
Setup proxy using a requests session instead of instantiating sockets
4191900
@tonybaloney
Fix test initialization and remove unused modules from httplib_ssl
10cea10
@tonybaloney
Consolidate LibcloudHTTPConnection and LibcloudHTTPSConnection into a…
30d27bb 
… single class. Create a session based wrapper for requests. Implement the SSL verification overridding.
@tonybaloney
Use PEP0328 to fix import errors now that I moved logging connection …
6cc6e3c 
…to a more logical module
@tonybaloney
Consolidate the logging connection into a single class now that the c…
d52e8ef 
…onnection classes are no longer a tuple
@tonybaloney
Fix remaining direct references to the direct module
de1176e
@tonybaloney
Refactor all the unit tests to only have 1 mock connection class and …
6fd28b6 
…use Connection.conn_class instead of Connection.conn_classes (tuple)
@tonybaloney
Update package import for logging connection
0f9f53e
@tonybaloney
Fix rackspace tests
0d1fdce
@tonybaloney
Fix linting errors
6326f98
@tonybaloney
Setup the error handling for the underlying requests library
9be69cc
@tonybaloney
Fix digital ocean tests
dc1290f
@tonybaloney
Fix brightbox testing
d95474e
@tonybaloney
Fix rackspace tests
14b68f5
@tonybaloney
Fix gridspot driver
0bfe15b
@tonybaloney
Fix cloudsigma tests
aac34de
@tonybaloney
Fix digital ocean tests
b164cfc
@tonybaloney
Fix brightbox tests
2195434
@tonybaloney
Fix iter methods for storage tests
52778e5
@tonybaloney
Fix cloudsigma tests
d0f6d22
@tonybaloney
Setup CA cert verification for compatibility with previous libcloud (…
3a492b8 
…but requests bundles CA now), fixed route53 tests, fixed httplib_ssl tests
@tonybaloney
Fix response class tests, fix route53 missing file. Added requests_mo…
6b9f90c 
…ck as a testing dependency.
@tonybaloney tonybaloney changed the title [WIP] Replaces httplib.request with requests library Replaces httplib.request with requests library Apr 5, 2016
@Kami
Copy link
Member

Kami commented Apr 8, 2016

I see you made no changes to the libcloud.utils.security module. What's our plan for that module?

Do we plan to remove and deprecate it or do we plan to keep it for backward compatibility reasons (this mostly means making sure VERIFY_SSL_CERT, SSL_VERSION and CA_CERT_PATH module level constants are still respected)?

@Kami Kami mentioned this pull request Jun 8, 2016
Merged
2 tasks
@tonybaloney tonybaloney mentioned this pull request Oct 25, 2016
Merged
@asfgit asfgit merged commit 2519c34 into apache:trunk Jan 9, 2017
@tonybaloney tonybaloney mentioned this pull request Jan 10, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tonybaloney @Kami @asfgit