New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces httplib.request with requests library #728

Merged
merged 32 commits into from Jan 9, 2017

Conversation

Projects
None yet
3 participants
@tonybaloney
Contributor

tonybaloney commented Mar 26, 2016

Todo:

  • map out dependencies for change
  • replace LibcloudHTTPConnection and LibcloudHTTPSconnection with requests powered connection classes
  • refactor out unneeded code from old libs, e.g. SSL validation
  • test

tonybaloney added some commits Mar 26, 2016

Move logging connection classes to another module -why don't people j…
…ust use a logging proxy instead? so much easier!
Consolidate LibcloudHTTPConnection and LibcloudHTTPSConnection into a…
… single class. Create a session based wrapper for requests. Implement the SSL verification overridding.
Refactor all the unit tests to only have 1 mock connection class and …
…use Connection.conn_class instead of Connection.conn_classes (tuple)
Setup CA cert verification for compatibility with previous libcloud (…
…but requests bundles CA now), fixed route53 tests, fixed httplib_ssl tests

@tonybaloney tonybaloney changed the title from [WIP] Replaces httplib.request with requests library to Replaces httplib.request with requests library Apr 5, 2016

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Apr 8, 2016

Member

I see you made no changes to the libcloud.utils.security module. What's our plan for that module?

Do we plan to remove and deprecate it or do we plan to keep it for backward compatibility reasons (this mostly means making sure VERIFY_SSL_CERT, SSL_VERSION and CA_CERT_PATH module level constants are still respected)?

Member

Kami commented Apr 8, 2016

I see you made no changes to the libcloud.utils.security module. What's our plan for that module?

Do we plan to remove and deprecate it or do we plan to keep it for backward compatibility reasons (this mostly means making sure VERIFY_SSL_CERT, SSL_VERSION and CA_CERT_PATH module level constants are still respected)?

@Kami Kami referenced this pull request Jun 8, 2016

Merged

[LIBCLOUD-827] Add support for automatic SNI #808

2 of 2 tasks complete

@asfgit asfgit merged commit 2519c34 into apache:trunk Jan 9, 2017

1 check failed

continuous-integration/travis-ci/push The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment