add ex_encrypted and ex_kms_key_id kwargs in EC2NodeDriver.create_volume #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3129,6 +3139,12 @@ def create_volume(self, size, name, location=None, snapshot=None, | |||
| if ex_volume_type == 'io1' and ex_iops: | |||
| params['Iops'] = ex_iops | |||
|
|
|||
| if ex_encrypted: | |||
There was a problem hiding this comment.
can you make value checks more explicit please e.g. if ex_encrypted is not None:
|
hi @ViktorOgnev thanks for your contribution, there are only a couple of changes before we can merge, first I made a comment about explicit "truthy" checking, can you fix that on both lines please. Second the lint is failing because 3 of the lines are too long, probably the docstring comments from a glance. you can run |
|
hi @tonybaloney , looks like now it's ok) Should I rebase, or is it fine as is? |
|
perfect, no need to squash, will merge. |
|
all done, thanks for your contribution @ViktorOgnev |
asfgit
pushed a commit
that referenced
this pull request
Mar 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.