New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ex_encrypted and ex_kms_key_id kwargs in EC2NodeDriver.create_volume #729

Closed
wants to merge 3 commits into
base: trunk
from

Conversation

Projects
None yet
2 participants
@ViktorOgnev
Contributor

ViktorOgnev commented Mar 28, 2016

No description provided.

Show outdated Hide outdated libcloud/compute/drivers/ec2.py
@@ -3129,6 +3139,12 @@ def create_volume(self, size, name, location=None, snapshot=None,
if ex_volume_type == 'io1' and ex_iops:
params['Iops'] = ex_iops
if ex_encrypted:

This comment has been minimized.

@tonybaloney

tonybaloney Mar 28, 2016

Contributor

can you make value checks more explicit please e.g. if ex_encrypted is not None:

@tonybaloney

tonybaloney Mar 28, 2016

Contributor

can you make value checks more explicit please e.g. if ex_encrypted is not None:

@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney

tonybaloney Mar 28, 2016

Contributor

hi @ViktorOgnev thanks for your contribution, there are only a couple of changes before we can merge, first I made a comment about explicit "truthy" checking, can you fix that on both lines please. Second the lint is failing because 3 of the lines are too long, probably the docstring comments from a glance. you can run flake8 locally to check the next commit.

Contributor

tonybaloney commented Mar 28, 2016

hi @ViktorOgnev thanks for your contribution, there are only a couple of changes before we can merge, first I made a comment about explicit "truthy" checking, can you fix that on both lines please. Second the lint is failing because 3 of the lines are too long, probably the docstring comments from a glance. you can run flake8 locally to check the next commit.

@ViktorOgnev

This comment has been minimized.

Show comment
Hide comment
@ViktorOgnev

ViktorOgnev Mar 28, 2016

Contributor

hi @tonybaloney , looks like now it's ok) Should I rebase, or is it fine as is?

Contributor

ViktorOgnev commented Mar 28, 2016

hi @tonybaloney , looks like now it's ok) Should I rebase, or is it fine as is?

@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney

tonybaloney Mar 28, 2016

Contributor

perfect, no need to squash, will merge.

Contributor

tonybaloney commented Mar 28, 2016

perfect, no need to squash, will merge.

@asfgit asfgit closed this in 7dc0fb0 Mar 28, 2016

@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney

tonybaloney Mar 28, 2016

Contributor

all done, thanks for your contribution @ViktorOgnev

Contributor

tonybaloney commented Mar 28, 2016

all done, thanks for your contribution @ViktorOgnev

asfgit pushed a commit that referenced this pull request Mar 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment