Outscale storage providers #730
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jmunhoz do they all need to be separate drivers? We are trying to make sure that there are single drivers with a |
jmunhoz
force-pushed
the
s3-rgw-outscale-providers
branch
from
6c3bd8a to
2d2bb42
Compare
|
@tonybaloney thanks for reviewing. As suggested I pushed a single driver with region support in the constructor. |
|
|
||
| class S3RGWOutscaleStorageDriver(S3StorageDriver): | ||
|
|
||
| def __init__(self, *args, **kwargs): |
There was a problem hiding this comment.
Please explicitly declare all the arguments where possible instead of using *args and **kwargs.
jmunhoz
force-pushed
the
s3-rgw-outscale-providers
branch
from
2d2bb42 to
e552b63
Compare
|
Hi @Kami, the new patch declares the arguments explicitly. |
|
Thanks @jmunhoz. the changes look great, merging |
asfgit
pushed a commit
that referenced
this pull request
Mar 31, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Outscale storage providers (Ceph RGW S3)