Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outscale storage providers #730

Closed
wants to merge 1 commit into from

Conversation

jmunhoz
Copy link
Contributor

@jmunhoz jmunhoz commented Mar 28, 2016

Add Outscale storage providers (Ceph RGW S3)

@tonybaloney
Copy link
Contributor

Hi @jmunhoz do they all need to be separate drivers? We are trying to make sure that there are single drivers with a region=x constructor.

@jmunhoz
Copy link
Contributor Author

jmunhoz commented Mar 30, 2016

@tonybaloney thanks for reviewing. As suggested I pushed a single driver with region support in the constructor.


class S3RGWOutscaleStorageDriver(S3StorageDriver):

def __init__(self, *args, **kwargs):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please explicitly declare all the arguments where possible instead of using *args and **kwargs.

@jmunhoz
Copy link
Contributor Author

jmunhoz commented Mar 31, 2016

Hi @Kami, the new patch declares the arguments explicitly.

@tonybaloney
Copy link
Contributor

Thanks @jmunhoz. the changes look great, merging

@asfgit asfgit closed this in 2a450e4 Mar 31, 2016
asfgit pushed a commit that referenced this pull request Mar 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants