New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outscale storage providers #730

Closed
wants to merge 1 commit into
base: trunk
from

Conversation

Projects
None yet
3 participants
@jmunhoz
Contributor

jmunhoz commented Mar 28, 2016

Add Outscale storage providers (Ceph RGW S3)

@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney

tonybaloney Mar 29, 2016

Contributor

Hi @jmunhoz do they all need to be separate drivers? We are trying to make sure that there are single drivers with a region=x constructor.

Contributor

tonybaloney commented Mar 29, 2016

Hi @jmunhoz do they all need to be separate drivers? We are trying to make sure that there are single drivers with a region=x constructor.

@jmunhoz

This comment has been minimized.

Show comment
Hide comment
@jmunhoz

jmunhoz Mar 30, 2016

Contributor

@tonybaloney thanks for reviewing. As suggested I pushed a single driver with region support in the constructor.

Contributor

jmunhoz commented Mar 30, 2016

@tonybaloney thanks for reviewing. As suggested I pushed a single driver with region support in the constructor.

Show outdated Hide outdated libcloud/storage/drivers/s3.py
class S3RGWOutscaleStorageDriver(S3StorageDriver):
def __init__(self, *args, **kwargs):

This comment has been minimized.

@Kami

Kami Mar 30, 2016

Member

Please explicitly declare all the arguments where possible instead of using *args and **kwargs.

@Kami

Kami Mar 30, 2016

Member

Please explicitly declare all the arguments where possible instead of using *args and **kwargs.

@jmunhoz

This comment has been minimized.

Show comment
Hide comment
@jmunhoz

jmunhoz Mar 31, 2016

Contributor

Hi @Kami, the new patch declares the arguments explicitly.

Contributor

jmunhoz commented Mar 31, 2016

Hi @Kami, the new patch declares the arguments explicitly.

@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney

tonybaloney Mar 31, 2016

Contributor

Thanks @jmunhoz. the changes look great, merging

Contributor

tonybaloney commented Mar 31, 2016

Thanks @jmunhoz. the changes look great, merging

@asfgit asfgit closed this in 2a450e4 Mar 31, 2016

asfgit pushed a commit that referenced this pull request Mar 31, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment