Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Checking the type of the IP with
explicit_ip_type
is not reliable.A fixed IP is not always a private IP and a floating IP is not always a public one.
So I moved up the check of the public subnets.
I also added the
addresses
element of the reply in theextra
dict.This allows users to implement their own algorithm to find the right IP (e.g. by network name).