Fix OpenStack IP type resolution #738
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. The change looks good to me, but it would be great if you can also add some tests cases for it. |
|
Ok, I will add a test case. |
|
Mention me when the test case has been added and I will go ahead and merge it. Thanks! |
|
@Kami I improved a bit the implementatino of the IP type resolution and updated tests accordingly. |
asfgit
pushed a commit
that referenced
this pull request
Apr 13, 2016
Closes #738 Signed-off-by: Tomaz Muraus <tomaz@tomaz.me>
asfgit
pushed a commit
that referenced
this pull request
Apr 13, 2016
Closes #738 Signed-off-by: Tomaz Muraus <tomaz@tomaz.me>
|
Merged into trunk. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Checking the type of the IP with
explicit_ip_typeis not reliable.A fixed IP is not always a private IP and a floating IP is not always a public one.
So I moved up the check of the public subnets.
I also added the
addresseselement of the reply in theextradict.This allows users to implement their own algorithm to find the right IP (e.g. by network name).