Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix OpenStack IP type resolution #738
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Kami
Apr 6, 2016
Member
Thanks.
The change looks good to me, but it would be great if you can also add some tests cases for it.
|
Thanks. The change looks good to me, but it would be great if you can also add some tests cases for it. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Ok, I will add a test case. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Kami
Apr 7, 2016
Member
Mention me when the test case has been added and I will go ahead and merge it.
Thanks!
|
Mention me when the test case has been added and I will go ahead and merge it. Thanks! |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
schaubl
Apr 13, 2016
Contributor
@Kami I improved a bit the implementatino of the IP type resolution and updated tests accordingly.
|
@Kami I improved a bit the implementatino of the IP type resolution and updated tests accordingly. |
asfgit
closed this
in
0bcc7d6
Apr 13, 2016
pushed a commit
that referenced
this pull request
Apr 13, 2016
pushed a commit
that referenced
this pull request
Apr 13, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Merged into trunk. Thanks! |
schaubl commentedApr 6, 2016
Checking the type of the IP with
explicit_ip_typeis not reliable.A fixed IP is not always a private IP and a floating IP is not always a public one.
So I moved up the check of the public subnets.
I also added the
addresseselement of the reply in theextradict.This allows users to implement their own algorithm to find the right IP (e.g. by network name).