Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaleway Compute Driver #777

Closed
wants to merge 4 commits into from
Closed

Scaleway Compute Driver #777

wants to merge 4 commits into from

Conversation

@bonifaido
Copy link
Contributor

@bonifaido bonifaido commented Apr 25, 2016

Scaleway Compute Driver

Description

This is a simple/pure compute driver for https://www.scaleway.com/

Status

Replace this: describe the PR status. Examples:

  • work in progress

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)
# limitations under the License.

import copy
import json
Copy link
Contributor

@tonybaloney tonybaloney Apr 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You would need to replace this with

try:
    import simplejson as json
except:
    import json

to keep py2 and py3 compat

Loading

@tonybaloney
Copy link
Contributor

@tonybaloney tonybaloney commented Apr 26, 2016

thanks @bonifaido for the contribution, I've made some comments on the conventions at the project that just need implementing, also it would be great to get docstrings and also a doc page on the driver, explain how the authentication mechanism works.
We also ask for tests and mock responses to be included for new drivers as well as an ICLA to be signed (if you haven't already).

Loading

@Kami
Copy link
Member

@Kami Kami commented Jun 4, 2016

@bonifaido How is this PR looking?

If you haven't already, can you please also sign an ICLA (https://libcloud.readthedocs.io/en/latest/development.html#contributing-bigger-changes) so we can move forward? Thanks.

Loading

@bonifaido
Copy link
Contributor Author

@bonifaido bonifaido commented Jun 7, 2016

Sorry, I haven't submitted the ICLA yet, will do it today.

Loading

@bonifaido bonifaido force-pushed the scaleway branch 2 times, most recently from 334f8a4 to 6b07207 Jun 11, 2016
@bonifaido
Copy link
Contributor Author

@bonifaido bonifaido commented Jun 11, 2016

Changes are done and squashed, please check them.

Loading

@kdeldycke
Copy link

@kdeldycke kdeldycke commented Jun 13, 2016

Thanks @bonifaido for this PR! 💯

BTW, you might find some useful snippets of code in our own python's SDK for mocking the account/token API (example: https://github.com/scaleway/python-scaleway/blob/v1.1.4/scaleway/tests/apis/test_api_account.py#L46-L62 ). Feel free to reuse them!

Loading

@kdeldycke
Copy link

@kdeldycke kdeldycke commented Jun 13, 2016

Here is a clean, transparent logo for the documentation.

scaleway-logo-flat-color

Loading

method='DELETE').success()

def destroy_volume_snapshot(self, snapshot):
return self.connection.request('/snapshots//%s' % snapshot.id,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo here: double slashes.

Loading

@tonybaloney
Copy link
Contributor

@tonybaloney tonybaloney commented Jun 24, 2016

@kdeldycke @bonifaido where are we up to with this PR?

Loading

@kdeldycke
Copy link

@kdeldycke kdeldycke commented Jun 24, 2016

@tonybaloney Don't know... Did @bonifaido signed the ICLA?

What's missing then? Tests and mocks?

Loading

@bonifaido
Copy link
Contributor Author

@bonifaido bonifaido commented Jun 29, 2016

Hi, sorry, not yet, I will do it tomorrow!

Loading

name=server['name'],
state=NodeState.fromstring(server['state']),
public_ips=[public_ip['address']] if public_ip else [],
private_ips=[private_ip['address']] if private_ip else [],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This didn't (any more?) work. The returned structure looked like:

      "public_ip": {
        "dynamic": false,
        "id": "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx",
        "address": "A.B.C.D"
      },
      "private_ip": "N.O.P.Q",

So changing this line to private_ips=[private_ip] if private_ip else [], made everything work ok for me.

Loading

Copy link
Contributor Author

@bonifaido bonifaido Oct 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, just fixed it, thanks!

Loading

@tonybaloney
Copy link
Contributor

@tonybaloney tonybaloney commented Oct 14, 2016

Thanks @bonifaido is this complete now?

Loading

@bonifaido
Copy link
Contributor Author

@bonifaido bonifaido commented Oct 26, 2016

There are no tests yet, but I don't have the time right now to write them, so if someone could write some basic tests for it it would be great.

Loading

@tonybaloney
Copy link
Contributor

@tonybaloney tonybaloney commented Apr 10, 2017

@bonifaido where is this up to?

Loading

@bonifaido
Copy link
Contributor Author

@bonifaido bonifaido commented Apr 10, 2017

Hello! Sorry I went away with this, but I'm not using the libcloud scaleway driver anymore, so I would be more than happy if somebody could take over this.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants