Skip to content

Add support for Google Compute Engine Image Families#778

Closed
wrigri wants to merge 1 commit intoapache:trunkfrom
wrigri:gce_image_family
Closed

Add support for Google Compute Engine Image Families#778
wrigri wants to merge 1 commit intoapache:trunkfrom
wrigri:gce_image_family

Conversation

@wrigri
Copy link
Contributor

@wrigri wrigri commented Apr 26, 2016

Support for Google Compute Engine Image Families

Description

Google Compute Engine has a new feature that allows one to specify an image using a "family". This will return the latest, non-deprecated image that has been created in the given project with that family attribute. This change adds support for using an image family in create_node and create_volume as well as a new method ex_get_image_from_family that will return an image resource from a family name.

Status

  • done, ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)

Lint is clean for the changes, the changes have nearly 100% test coverage, and docstrings have been updated appropriately.

@wrigri
Copy link
Contributor Author

wrigri commented Apr 26, 2016

cc @erjohnso

@erjohnso
Copy link
Contributor

LGTM @wrigri, could you squash commits please?

Add the ability to specify an "Image Family" for creating a node and/or
volume, and the ability to get an image object from a family name.
@wrigri
Copy link
Contributor Author

wrigri commented Apr 28, 2016

Commits squashed.

BTW, apparently github has a new feature as of this month that allows commits to be automatically squashed at merge time: https://github.com/blog/2141-squash-your-commits

@asfgit asfgit closed this in 5c09af2 Apr 28, 2016
asfgit pushed a commit that referenced this pull request Apr 30, 2016
Closes LIBCLOUD-713
Closes #778

Signed-off-by: Eric Johnson <erjohnso@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants