New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Google Compute Engine Image Families #778

Closed
wants to merge 1 commit into
base: trunk
from

Conversation

Projects
None yet
2 participants
@wrigri
Contributor

wrigri commented Apr 26, 2016

Support for Google Compute Engine Image Families

Description

Google Compute Engine has a new feature that allows one to specify an image using a "family". This will return the latest, non-deprecated image that has been created in the given project with that family attribute. This change adds support for using an image family in create_node and create_volume as well as a new method ex_get_image_from_family that will return an image resource from a family name.

Status

  • done, ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)

Lint is clean for the changes, the changes have nearly 100% test coverage, and docstrings have been updated appropriately.

@wrigri

This comment has been minimized.

Show comment
Hide comment
@wrigri

wrigri Apr 26, 2016

Contributor
Contributor

wrigri commented Apr 26, 2016

@erjohnso

This comment has been minimized.

Show comment
Hide comment
@erjohnso

erjohnso Apr 28, 2016

Member

LGTM @wrigri, could you squash commits please?

Member

erjohnso commented Apr 28, 2016

LGTM @wrigri, could you squash commits please?

Add support for Google Compute Engine Image Families
Add the ability to specify an "Image Family" for creating a node and/or
volume, and the ability to get an image object from a family name.
@wrigri

This comment has been minimized.

Show comment
Hide comment
@wrigri

wrigri Apr 28, 2016

Contributor

Commits squashed.

BTW, apparently github has a new feature as of this month that allows commits to be automatically squashed at merge time: https://github.com/blog/2141-squash-your-commits

Contributor

wrigri commented Apr 28, 2016

Commits squashed.

BTW, apparently github has a new feature as of this month that allows commits to be automatically squashed at merge time: https://github.com/blog/2141-squash-your-commits

@asfgit asfgit closed this in 5c09af2 Apr 28, 2016

asfgit pushed a commit that referenced this pull request Apr 30, 2016

[google compute] fix missing pricing data
Closes LIBCLOUD-713
Closes #778

Signed-off-by: Eric Johnson <erjohnso@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment