New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to provision node with subnetwork #783

Closed
wants to merge 7 commits into
base: trunk
from

Conversation

Projects
None yet
2 participants
@larsla
Contributor

larsla commented May 10, 2016

Option to provision node with subnetwork

Description

This PR relates to #780, but adds the option to specify a subnetwork when creating a node.

Status

  • done, ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)
@erjohnso

This comment has been minimized.

Show comment
Hide comment
@erjohnso

erjohnso May 10, 2016

Member

Holy moly @larsla - this is awesome timing and thank you! I was just starting my day by getting ready to do this myself, but now I can watch cat videos on youtube instead! 👍

Did you want to take a pass at adding tests for this? If not, I'm happy to do that (since I planned to do it anyway).

Member

erjohnso commented May 10, 2016

Holy moly @larsla - this is awesome timing and thank you! I was just starting my day by getting ready to do this myself, but now I can watch cat videos on youtube instead! 👍

Did you want to take a pass at adding tests for this? If not, I'm happy to do that (since I planned to do it anyway).

@larsla

This comment has been minimized.

Show comment
Hide comment
@larsla

larsla May 10, 2016

Contributor

:)

I didn't have time to look at the tests yet, so please go ahead if you like.

Contributor

larsla commented May 10, 2016

:)

I didn't have time to look at the tests yet, so please go ahead if you like.

@erjohnso

This comment has been minimized.

Show comment
Hide comment
@erjohnso

erjohnso May 10, 2016

Member

Works for me. I'll work of your stuff.

Member

erjohnso commented May 10, 2016

Works for me. I'll work of your stuff.

erjohnso added a commit to erjohnso/libcloud that referenced this pull request May 10, 2016

@erjohnso

This comment has been minimized.

Show comment
Hide comment
@erjohnso

erjohnso May 10, 2016

Member

@larsla - let me know if this works for you. If you're happy with it and get it added to your branch, could you squash your commits (fine to collapse mine too).

Member

erjohnso commented May 10, 2016

@larsla - let me know if this works for you. If you're happy with it and get it added to your branch, could you squash your commits (fine to collapse mine too).

@erjohnso

This comment has been minimized.

Show comment
Hide comment
@erjohnso

erjohnso May 11, 2016

Member

@larsla - if you're OK with these tests, I can go ahead and do the cleanup/merge.

Member

erjohnso commented May 11, 2016

@larsla - if you're OK with these tests, I can go ahead and do the cleanup/merge.

@asfgit asfgit closed this in 9639726 May 17, 2016

asfgit pushed a commit that referenced this pull request May 17, 2016

adding tests for #783
Signed-off-by: Eric Johnson <erjohnso@google.com>
@erjohnso

This comment has been minimized.

Show comment
Hide comment
@erjohnso

erjohnso May 17, 2016

Member

Thanks again for this @larsla!

Member

erjohnso commented May 17, 2016

Thanks again for this @larsla!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment