Option to provision node with subnetwork #783
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Holy moly @larsla - this is awesome timing and thank you! I was just starting my day by getting ready to do this myself, but now I can watch cat videos on youtube instead! 👍 Did you want to take a pass at adding tests for this? If not, I'm happy to do that (since I planned to do it anyway). |
|
:) I didn't have time to look at the tests yet, so please go ahead if you like. |
|
Works for me. I'll work of your stuff. |
erjohnso
added a commit
to erjohnso/libcloud
that referenced
this pull request
May 10, 2016
|
@larsla - let me know if this works for you. If you're happy with it and get it added to your branch, could you squash your commits (fine to collapse mine too). |
|
@larsla - if you're OK with these tests, I can go ahead and do the cleanup/merge. |
asfgit
pushed a commit
that referenced
this pull request
May 17, 2016
Signed-off-by: Eric Johnson <erjohnso@google.com>
|
Thanks again for this @larsla! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Option to provision node with subnetwork
Description
This PR relates to #780, but adds the option to specify a subnetwork when creating a node.
Status
Checklist (tick everything that applies)