Updated create_volume routine in the cloudstack.py file to support ex_volume_type #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"DiskOffering" selection using same variable name as for OpenStack (ex_volume_type). This allows one to specify a specific volume type. When ex_volume_type is specified, the size of the volume is defined by that volume type, unless it is adjustable. Updated tests to validate changes to create_volume.
…ck driver in libcloud. Removed a single trailing space from driver module.
|
Thanks and sorry for the delay. The change looks good to me. /cc @Runseb |
|
The changes look good to me so I went and merged them into trunk - thanks! In the future, please make sure that git author field is correctly configured for each commit (looks like a second commit was made from a different (root) user account which didn't have git user name and email configured so I squashed that commit into the previous one). |
|
Thank you. I had to stand up a new VM to get the test harness working and pushed from the wrong place. Ugh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Updated create_volume routine in the cloudstack.py file to support ex_volume_type
Description
As part of the deployment of an internal cloud using CloudStack, we discovered that
one cannot use the "DiskOffering" capability of CloudStack to select volumes with
specific attributes. When reviewing the OpenStack portion of the library, this is
supported using the ex_volume_type variable in the call to create_volume.
The CloudStack DiskOffering capability is required for this deployment, so the create_volume
routing in cloudstack.py was updated to add this as an option using the same variable name
as used for OpenStack.
When a DiskOffering is specified, the input size to create_volume is over-riden by the
size of the DiskOffering, unless the DiskOffering size is customizable. This was chosen
to minimize errors, as if someone calls create_volume with the ex_volume_type option,
then it is likely that is what they want, even if the specified size is different from the request.
Status
Checklist (tick everything that applies)