New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated create_volume routine in the cloudstack.py file to support ex_volume_type #785

Closed
wants to merge 2 commits into
base: trunk
from

Conversation

Projects
None yet
2 participants
@gregorybishop
Contributor

gregorybishop commented May 11, 2016

Updated create_volume routine in the cloudstack.py file to support ex_volume_type

Description

As part of the deployment of an internal cloud using CloudStack, we discovered that
one cannot use the "DiskOffering" capability of CloudStack to select volumes with
specific attributes. When reviewing the OpenStack portion of the library, this is
supported using the ex_volume_type variable in the call to create_volume.

The CloudStack DiskOffering capability is required for this deployment, so the create_volume
routing in cloudstack.py was updated to add this as an option using the same variable name
as used for OpenStack.

When a DiskOffering is specified, the input size to create_volume is over-riden by the
size of the DiskOffering, unless the DiskOffering size is customizable. This was chosen
to minimize errors, as if someone calls create_volume with the ex_volume_type option,
then it is likely that is what they want, even if the specified size is different from the request.

Status

  • done, ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)

gregorybishop and others added some commits May 11, 2016

Updated create_volume routine in the cloudstack.py file to support
"DiskOffering" selection using same variable name as for OpenStack
(ex_volume_type). This allows one to specify a specific volume type.
When ex_volume_type is specified, the size of the volume is defined
by that volume type, unless it is adjustable. Updated
tests to validate changes to create_volume.
root
Updated tests related to adding support for DiskOfferings to CloudSta…
…ck driver

in libcloud.

Removed a single trailing space from driver module.
@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Jun 4, 2016

Member

Thanks and sorry for the delay.

The change looks good to me.

/cc @runseb

Member

Kami commented Jun 4, 2016

Thanks and sorry for the delay.

The change looks good to me.

/cc @runseb

@asfgit asfgit closed this in 93111df Jun 4, 2016

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Jun 4, 2016

Member

The changes look good to me so I went and merged them into trunk - thanks!

In the future, please make sure that git author field is correctly configured for each commit (looks like a second commit was made from a different (root) user account which didn't have git user name and email configured so I squashed that commit into the previous one).

Member

Kami commented Jun 4, 2016

The changes look good to me so I went and merged them into trunk - thanks!

In the future, please make sure that git author field is correctly configured for each commit (looks like a second commit was made from a different (root) user account which didn't have git user name and email configured so I squashed that commit into the previous one).

@gregorybishop

This comment has been minimized.

Show comment
Hide comment
@gregorybishop

gregorybishop Jun 5, 2016

Contributor

Thank you.

I had to stand up a new VM to get the test harness working and pushed from the wrong place. Ugh.

Contributor

gregorybishop commented Jun 5, 2016

Thank you.

I had to stand up a new VM to get the test harness working and pushed from the wrong place. Ugh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment