adding dns support for dnspod provider #787

jetbird · May 15, 2016

DNS support for DNSPod provider

Description

I coded the dns driver for DNSPod on libcloud/dns/drivers/dnspod.py module. In order for this driver to work the libcloud/common/dnspod.py module is needed. The unitttests for this driver are coded in the libcloud/test/dns/test_dnspod.py module.

Status

done, ready for review

Checklist (tick everything that applies)

Code linting (required, can be done after the PR checks)
Documentation
Tests
ICLA (required for bigger changes)

Great, thanks.

Is the PR already for a review, or are you still working on it?

Kami · May 15, 2016

Great, thanks.

Is the PR already for a review, or are you still working on it?

@Kami the pr is ready for review :)

jetbird · May 15, 2016

@Kami the pr is ready for review :)

Kami · May 16, 2016

Kami reviewed May 16, 2016

View changes

Kami · May 16, 2016

libcloud/test/dns/test_dnspod.py

+                                                           url, body, headers):
+        body = self.fixtures.load('delete_record_record_does_not_exist.json')
+
+        return httplib.OK, body, {}, httplib.responses[httplib.OK]


Just curious - does API indeed return 200 status code for all the different responses?

Kami · May 16, 2016

Kami reviewed May 16, 2016

View changes

Kami · May 16, 2016

libcloud/common/dnspod.py

@@ -0,0 +1,65 @@
+from libcloud.common.base import ConnectionKey, JsonResponse


Please add a missing Apache license header.

Kami · May 16, 2016

Kami reviewed May 16, 2016

View changes

Kami · May 16, 2016

libcloud/common/dnspod.py

+    def add_default_headers(self, headers):
+        headers['Content-Type'] = 'application/x-www-form-urlencoded'
+        headers['Accept'] = 'text/json'
+        headers['User-Agent'] = \


Please remove this, libcloud includes it's own custom User-Agent header (it includes version of Libcloud and driver user).

Kami · May 16, 2016

Kami reviewed May 16, 2016

View changes

Kami · May 16, 2016

libcloud/dns/drivers/dnspod.py

+
+    def list_zones(self):
+        action = '/Domain.List'
+        data = {'user_token': self.key, 'format': 'json'}


user_token and format attributes seem to be included in every request so you could maybe refactor this a bit and include those attributes somewhere else (e.g. inside the connection request method or similar) so the same piece of code doesn't need to be repeated all over.

@Kami yes i thought about that, how to include that in every request?

@Kami hey man any update on this? I have fixed the other problems, this is the only one left.

As mentioned in my comment above, you could refactor that functionality in a custom request method on the connection class.

You can find a similar example here - https://github.com/apache/libcloud/blob/trunk/libcloud/dns/drivers/cloudflare.py#L106

Kami · May 16, 2016

Kami reviewed May 16, 2016

View changes

Kami · May 16, 2016

libcloud/dns/drivers/dnspod.py

+            e = sys.exc_info()[1]
+            if e.message == 'No domains':
+                return []
+        zones = self._to_zones(items=response.parse_body()['domains'])


Libcloud already parses the body for you and is available via response.object attribute.

No need to call parse_body yourself.

Kami · May 16, 2016

Kami reviewed May 16, 2016

View changes

Kami · May 16, 2016

libcloud/dns/drivers/dnspod.py

+                                               data=data)
+        except DNSPodException:
+            e = sys.exc_info()[1]
+            if e.message in ['Domain is exists',


You could save those messages in a constant, e.g. ZONE_ALREADY_EXISTS_ERROR_MSGS = [ ... ].

Thanks 👍

I've added some in-line comments.

Kami · May 16, 2016

Thanks 👍

I've added some in-line comments.

@jetbird Did you push your latest changes?

Since I don't see any new commits (license header is still missing, etc.).

Kami · May 21, 2016

@jetbird Did you push your latest changes?

Since I don't see any new commits (license header is still missing, etc.).

@Kami done :)

jetbird · May 23, 2016

@Kami done :)

@jetbird Thanks.

I've made some changes and fixes (6594a46, defff8a) and merged patch into trunk.

As you can see in the second commit (defff8a), _make_request method didn't actually do anything with the method argument (a bug which existing tests don't catch). That was masked by (ab)using **kwargs - that's a good example of why **kwargs should be avoided in scenarios like that and only used when there is a valid need for it.

Kami · May 25, 2016

@jetbird Thanks.

I've made some changes and fixes (6594a46, defff8a) and merged patch into trunk.

As you can see in the second commit (defff8a), _make_request method didn't actually do anything with the method argument (a bug which existing tests don't catch). That was masked by (ab)using **kwargs - that's a good example of why **kwargs should be avoided in scenarios like that and only used when there is a valid need for it.

@jetbird Can you please test latest changes against the live provider API?

Kami · May 25, 2016

@jetbird Can you please test latest changes against the live provider API?

Thanks for explaining the fixes :) Of course, I will test it now.

jetbird · May 25, 2016

Thanks for explaining the fixes :) Of course, I will test it now.

@Kami Tested. It works fine for me :)

jetbird · May 25, 2016

@Kami Tested. It works fine for me :)

@jetbird Great 👍

It would also be good if you can add some basic docs for the driver and contact the provider (tall them about Libcloud, driver, etc. and ask them if it's possible to mention it somewhere on the page / docs, etc.).

Kami · May 25, 2016

@jetbird Great 👍

It would also be good if you can add some basic docs for the driver and contact the provider (tall them about Libcloud, driver, etc. and ask them if it's possible to mention it somewhere on the page / docs, etc.).

places error messages in lists, fixes the duplicate problem data param
creates, removes uneeded default headers, calling response.object instead of response.parse_body

d82d7b2

asfgit closed this in 707a725 May 25, 2016

asfgit pushed a commit that referenced this pull request May 25, 2016

updates the secrets file
Closes #787 Signed-off-by: Tomaz Muraus <tomaz@tomaz.me>

47db6ce

asfgit pushed a commit that referenced this pull request May 25, 2016

updates the driver
Closes #787 Signed-off-by: Tomaz Muraus <tomaz@tomaz.me>

4617707

asfgit pushed a commit that referenced this pull request May 25, 2016

updates code to pep8 standards, uses urlencode to support different p…
…ython versions Closes #787 Signed-off-by: Tomaz Muraus <tomaz@tomaz.me>

10b7c2b

asfgit pushed a commit that referenced this pull request May 25, 2016

removes unused import statements such as import urllib
Closes #787 Signed-off-by: Tomaz Muraus <tomaz@tomaz.me>

f08b6ee

asfgit pushed a commit that referenced this pull request May 25, 2016

fixes the lint for test_dnspod module
Closes #787 Signed-off-by: Tomaz Muraus <tomaz@tomaz.me>

f9358b6

apache/libcloud

Join GitHub today

adding dns support for dnspod provider #787

Conversation

jetbird commented May 15, 2016 • edited Edited 1 time jetbird edited May 15, 2016 (most recent)

DNS support for DNSPod provider

Description

Status

Checklist (tick everything that applies)

This comment has been minimized.

Kami commented May 15, 2016

This comment has been minimized.

jetbird commented May 15, 2016

jetbird added some commits May 15, 2016

Kami reviewed May 16, 2016 View changes

This comment has been minimized.

Kami reviewed May 16, 2016 View changes

This comment has been minimized.

Kami reviewed May 16, 2016 View changes

This comment has been minimized.

Kami reviewed May 16, 2016 View changes

This comment has been minimized.

This comment has been minimized.

jetbird May 18, 2016 • edited Edited 1 time jetbird edited May 19, 2016 (most recent)

This comment has been minimized.

jetbird May 20, 2016 • edited Edited 1 time jetbird edited May 20, 2016 (most recent)

This comment has been minimized.

Kami reviewed May 16, 2016 View changes

This comment has been minimized.

Kami reviewed May 16, 2016 View changes

This comment has been minimized.

This comment has been minimized.

Kami commented May 16, 2016

This comment has been minimized.

Kami commented May 21, 2016

This comment has been minimized.

jetbird commented May 23, 2016

asfgit closed this in 707a725 May 25, 2016

asfgit pushed a commit that referenced this pull request May 25, 2016

asfgit pushed a commit that referenced this pull request May 25, 2016

asfgit pushed a commit that referenced this pull request May 25, 2016

asfgit pushed a commit that referenced this pull request May 25, 2016

asfgit pushed a commit that referenced this pull request May 25, 2016

asfgit pushed a commit that referenced this pull request May 25, 2016

This comment has been minimized.

Kami commented May 25, 2016

This comment has been minimized.

Kami commented May 25, 2016

This comment has been minimized.

jetbird commented May 25, 2016

This comment has been minimized.

jetbird commented May 25, 2016 • edited Edited 1 time jetbird edited May 25, 2016 (most recent)

This comment has been minimized.

Kami commented May 25, 2016

jetbird commented May 15, 2016 •

edited

Edited 1 time

jetbird edited May 15, 2016 (most recent)

Kami reviewed May 16, 2016

View changes

Kami reviewed May 16, 2016

View changes

Kami reviewed May 16, 2016

View changes

Kami reviewed May 16, 2016

View changes

jetbird May 18, 2016 •

edited

Edited 1 time

jetbird edited May 19, 2016 (most recent)

jetbird May 20, 2016 •

edited

Edited 1 time

jetbird edited May 20, 2016 (most recent)

Kami reviewed May 16, 2016

View changes

Kami reviewed May 16, 2016

View changes

asfgit closed this in `707a725` May 25, 2016

jetbird commented May 25, 2016 •

edited

Edited 1 time

jetbird edited May 25, 2016 (most recent)