adding dns support for dnspod provider #787

jetbird · 2016-05-15T17:05:09Z

DNS support for DNSPod provider

Description

I coded the dns driver for DNSPod on libcloud/dns/drivers/dnspod.py module. In order for this driver to work the libcloud/common/dnspod.py module is needed. The unitttests for this driver are coded in the libcloud/test/dns/test_dnspod.py module.

Status

done, ready for review

Checklist (tick everything that applies)

Code linting (required, can be done after the PR checks)
Documentation
Tests
ICLA (required for bigger changes)

Kami · 2016-05-15T17:37:29Z

Great, thanks.

Is the PR already for a review, or are you still working on it?

jetbird · 2016-05-15T18:33:52Z

@Kami the pr is ready for review :)

…ython versions

Kami · 2016-05-16T15:58:52Z

libcloud/test/dns/test_dnspod.py

+                                                           url, body, headers):
+        body = self.fixtures.load('delete_record_record_does_not_exist.json')
+
+        return httplib.OK, body, {}, httplib.responses[httplib.OK]


Just curious - does API indeed return 200 status code for all the different responses?

Kami · 2016-05-16T15:59:57Z

libcloud/common/dnspod.py

@@ -0,0 +1,65 @@
+from libcloud.common.base import ConnectionKey, JsonResponse


Please add a missing Apache license header.

Kami · 2016-05-16T16:00:38Z

libcloud/common/dnspod.py

+    def add_default_headers(self, headers):
+        headers['Content-Type'] = 'application/x-www-form-urlencoded'
+        headers['Accept'] = 'text/json'
+        headers['User-Agent'] = \


Please remove this, libcloud includes it's own custom User-Agent header (it includes version of Libcloud and driver user).

Kami · 2016-05-16T16:01:42Z

libcloud/dns/drivers/dnspod.py

+
+    def list_zones(self):
+        action = '/Domain.List'
+        data = {'user_token': self.key, 'format': 'json'}


user_token and format attributes seem to be included in every request so you could maybe refactor this a bit and include those attributes somewhere else (e.g. inside the connection request method or similar) so the same piece of code doesn't need to be repeated all over.

@Kami yes i thought about that, how to include that in every request?

@Kami hey man any update on this? I have fixed the other problems, this is the only one left.

As mentioned in my comment above, you could refactor that functionality in a custom request method on the connection class.

You can find a similar example here - https://github.com/apache/libcloud/blob/trunk/libcloud/dns/drivers/cloudflare.py#L106

Kami · 2016-05-16T16:02:33Z

libcloud/dns/drivers/dnspod.py

+            e = sys.exc_info()[1]
+            if e.message == 'No domains':
+                return []
+        zones = self._to_zones(items=response.parse_body()['domains'])


Libcloud already parses the body for you and is available via response.object attribute.

No need to call parse_body yourself.

Kami · 2016-05-16T16:03:18Z

libcloud/dns/drivers/dnspod.py

+                                               data=data)
+        except DNSPodException:
+            e = sys.exc_info()[1]
+            if e.message in ['Domain is exists',


You could save those messages in a constant, e.g. ZONE_ALREADY_EXISTS_ERROR_MSGS = [ ... ].

Kami · 2016-05-16T16:04:19Z

Thanks 👍

I've added some in-line comments.

Kami · 2016-05-21T09:13:50Z

@jetbird Did you push your latest changes?

Since I don't see any new commits (license header is still missing, etc.).

jetbird · 2016-05-23T22:40:46Z

@Kami done :)

creates, removes uneeded default headers, calling response.object instead of response.parse_body

Closes #787 Signed-off-by: Tomaz Muraus <tomaz@tomaz.me>

…ython versions Closes #787 Signed-off-by: Tomaz Muraus <tomaz@tomaz.me>

Closes #787 Signed-off-by: Tomaz Muraus <tomaz@tomaz.me>

…m creates, removes uneeded default headers, calling response.object instead of response.parse_body Closes #787 Signed-off-by: Tomaz Muraus <tomaz@tomaz.me>

Kami · 2016-05-25T12:51:53Z

@jetbird Thanks.

I've made some changes and fixes (6594a46, defff8a) and merged patch into trunk.

As you can see in the second commit (defff8a), _make_request method didn't actually do anything with the method argument (a bug which existing tests don't catch). That was masked by (ab)using **kwargs - that's a good example of why **kwargs should be avoided in scenarios like that and only used when there is a valid need for it.

Kami · 2016-05-25T12:52:29Z

@jetbird Can you please test latest changes against the live provider API?

jetbird · 2016-05-25T15:48:19Z

Thanks for explaining the fixes :) Of course, I will test it now.

jetbird · 2016-05-25T17:27:31Z

@Kami Tested. It works fine for me :)

Kami · 2016-05-25T19:26:11Z

@jetbird Great 👍

It would also be good if you can add some basic docs for the driver and contact the provider (tall them about Libcloud, driver, etc. and ask them if it's possible to mention it somewhere on the page / docs, etc.).

jetbird added 6 commits May 15, 2016

adding dns support for dnspod provider

Loading status checks…

a612cbf

updates the secrets file

Loading status checks…

bc4bfd2

updates the driver

Loading status checks…

f9233b8

updates code to pep8 standards, uses urlencode to support different p…

Loading status checks…

5aedd26

…ython versions

removes unused import statements such as import urllib

Loading status checks…

9b51377

fixes the lint for test_dnspod module

Loading status checks…

6ee66a8

Kami reviewed May 16, 2016
View changes

libcloud/common/dnspod.py

@@ -0,0 +1,65 @@

from libcloud.common.base import ConnectionKey, JsonResponse

This comment has been minimized.

Sign in to view

Kami May 16, 2016
Member

Please add a missing Apache license header.

Kami reviewed May 16, 2016
View changes

places error messages in lists, fixes the duplicate problem data param

Loading status checks…

d82d7b2

creates, removes uneeded default headers, calling response.object instead of response.parse_body

asfgit closed this in 707a725 May 25, 2016

asfgit pushed a commit that referenced this pull request May 25, 2016

updates the secrets file

47db6ce

Closes #787 Signed-off-by: Tomaz Muraus <tomaz@tomaz.me>

asfgit pushed a commit that referenced this pull request May 25, 2016

updates the driver

4617707

Closes #787 Signed-off-by: Tomaz Muraus <tomaz@tomaz.me>

asfgit pushed a commit that referenced this pull request May 25, 2016

updates code to pep8 standards, uses urlencode to support different p…

10b7c2b

…ython versions Closes #787 Signed-off-by: Tomaz Muraus <tomaz@tomaz.me>

asfgit pushed a commit that referenced this pull request May 25, 2016

removes unused import statements such as import urllib

f08b6ee

Closes #787 Signed-off-by: Tomaz Muraus <tomaz@tomaz.me>

asfgit pushed a commit that referenced this pull request May 25, 2016

fixes the lint for test_dnspod module

f9358b6

Closes #787 Signed-off-by: Tomaz Muraus <tomaz@tomaz.me>

apache / libcloud

adding dns support for dnspod provider #787

adding dns support for dnspod provider #787

jetbird commented May 15, 2016 •

edited

Kami commented May 15, 2016

jetbird commented May 15, 2016

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Kami commented May 16, 2016

Kami commented May 21, 2016

jetbird commented May 23, 2016

Kami commented May 25, 2016

Kami commented May 25, 2016

jetbird commented May 25, 2016

jetbird commented May 25, 2016 •

edited

Kami commented May 25, 2016

		@@ -0,0 +1,65 @@
		from libcloud.common.base import ConnectionKey, JsonResponse

apache / libcloud

adding dns support for dnspod provider #787

adding dns support for dnspod provider #787

Conversation

jetbird commented May 15, 2016 • edited

DNS support for DNSPod provider

Description

Status

Checklist (tick everything that applies)

Kami commented May 15, 2016

jetbird commented May 15, 2016

This comment has been minimized.

Kami May 16, 2016 Member

This comment has been minimized.

Kami May 16, 2016 Member

This comment has been minimized.

Kami May 16, 2016 Member

This comment has been minimized.

Kami May 16, 2016 Member

This comment has been minimized.

jetbird May 18, 2016 • edited Author Contributor

This comment has been minimized.

jetbird May 20, 2016 • edited Author Contributor

This comment has been minimized.

Kami May 21, 2016 Member

This comment has been minimized.

Kami May 16, 2016 Member

This comment has been minimized.

Kami May 16, 2016 Member

Kami commented May 16, 2016

Kami commented May 21, 2016

jetbird commented May 23, 2016

Kami commented May 25, 2016

Kami commented May 25, 2016

jetbird commented May 25, 2016

jetbird commented May 25, 2016 • edited

Kami commented May 25, 2016

jetbird commented May 15, 2016 •

edited

Kami May 16, 2016
Member

Kami May 16, 2016
Member

Kami May 16, 2016
Member

Kami May 16, 2016
Member

jetbird May 18, 2016 •

edited

Author Contributor

jetbird May 20, 2016 •

edited

Author Contributor

Kami May 21, 2016
Member

Kami May 16, 2016
Member

Kami May 16, 2016
Member

jetbird commented May 25, 2016 •

edited