Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
[LIBCLOUD-820] added check if libvirt uri is local #788
LIBCLOUD-820 added check if libvirt uri is local
without this listing nodes on a remote libvirtd server will fail to
Checklist (tick everything that applies)
The change looks good to me.
As far as root requirement goes - I would prefer to stick to a tool which is available by default on most Linux distributions. Having said that, I would be fine with trying to use iproute2 first and falling back to arp if iproute2 is not available.