New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenStackIdentity_3_0_Connection child class to manage auth with OpenID access tokens #789

Closed
wants to merge 8 commits into
base: trunk
from

Conversation

Projects
None yet
3 participants
@micafer
Contributor

micafer commented May 18, 2016

Add OpenStackIdentity_3_0_Connection child class to manage auth with OpenID access tokens

Description

The class OpenStackIdentity_3_0_Connection_OIDC_access_token has been added to enable OpenStack driver to manage OpenID access tokens to get access to an OpenStack site.

http://docs.openstack.org/developer/keystone/extensions/openidc.html

Status

  • done, ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)
@alvarolopez

This comment has been minimized.

Show comment
Hide comment
@alvarolopez

alvarolopez May 18, 2016

"oidc" is not something fixed, as it is an arbitrary string configurable at each Keystone endpoint, so it should be provided by the user.

alvarolopez commented on libcloud/common/openstack_identity.py in 3ab6888 May 18, 2016

"oidc" is not something fixed, as it is an arbitrary string configurable at each Keystone endpoint, so it should be provided by the user.

@alvarolopez

This comment has been minimized.

Show comment
Hide comment
@alvarolopez

alvarolopez May 18, 2016

I would rename it as "3.x_oidc_access_token".

I would rename it as "3.x_oidc_access_token".

@alvarolopez

This comment has been minimized.

Show comment
Hide comment
@alvarolopez

alvarolopez May 18, 2016

Same here. I would rename it to make clear that this is based on using a OIDC access token that we obtained from elsewhere.

Same here. I would rename it to make clear that this is based on using a OIDC access token that we obtained from elsewhere.

@alvarolopez

This comment has been minimized.

Show comment
Hide comment
@alvarolopez

alvarolopez May 18, 2016

s/token/access token/

s/token/access token/

This comment has been minimized.

Show comment
Hide comment
@micafer

micafer May 18, 2016

Collaborator

@alvarolopez I have change all the suggested changes.

Collaborator

micafer replied May 18, 2016

@alvarolopez I have change all the suggested changes.

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami May 19, 2016

Member

Thanks for the contribution! I will look into it shorty.

In the mean time, would it be possible to add some tests for this new authentication method?

Member

Kami commented May 19, 2016

Thanks for the contribution! I will look into it shorty.

In the mean time, would it be possible to add some tests for this new authentication method?

@micafer

This comment has been minimized.

Show comment
Hide comment
@micafer

micafer May 20, 2016

Contributor

@Kami I have added tests for the new authentication method.

Contributor

micafer commented May 20, 2016

@Kami I have added tests for the new authentication method.

@asfgit asfgit closed this in 8f97bb4 May 26, 2016

asfgit pushed a commit that referenced this pull request May 26, 2016

Style changes
Closes #789

Signed-off-by: Tomaz Muraus <tomaz@tomaz.me>

asfgit pushed a commit that referenced this pull request May 26, 2016

Code improvements
Closes #789

Signed-off-by: Tomaz Muraus <tomaz@tomaz.me>

asfgit pushed a commit that referenced this pull request May 26, 2016

Code improvements
Closes #789

Signed-off-by: Tomaz Muraus <tomaz@tomaz.me>

asfgit pushed a commit that referenced this pull request May 26, 2016

Minor bugfix
Closes #789

Signed-off-by: Tomaz Muraus <tomaz@tomaz.me>

asfgit pushed a commit that referenced this pull request May 26, 2016

Minor change
Closes #789

Signed-off-by: Tomaz Muraus <tomaz@tomaz.me>

asfgit pushed a commit that referenced this pull request May 26, 2016

Improve comments
Closes #789

Signed-off-by: Tomaz Muraus <tomaz@tomaz.me>

asfgit pushed a commit that referenced this pull request May 26, 2016

Add tests for class OpenStackIdentity_3_0_Connection_OIDC_access_token
Closes #789

Signed-off-by: Tomaz Muraus <tomaz@tomaz.me>
@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami May 26, 2016

Member

Thanks and sorry for the delay.

The changes look good to me so I went ahead and merged them into trunk.

When you get a chance it would also be great if you can add some documentation on how to authenticate against OpenStack based clouds using a token.

Also, since this is a bigger change, can you please also file an ICLA - https://libcloud.readthedocs.io/en/latest/development.html#contributing-bigger-changes

Member

Kami commented May 26, 2016

Thanks and sorry for the delay.

The changes look good to me so I went ahead and merged them into trunk.

When you get a chance it would also be great if you can add some documentation on how to authenticate against OpenStack based clouds using a token.

Also, since this is a bigger change, can you please also file an ICLA - https://libcloud.readthedocs.io/en/latest/development.html#contributing-bigger-changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment