New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amazon suggests using signature_version 4 for accessing the elasticlo… #796

Closed
wants to merge 2 commits into
base: trunk
from

Conversation

Projects
None yet
2 participants
@paepke
Contributor

paepke commented May 27, 2016

[LIBCLOUD-824] Elastic loadbalancer signature version 4

Description

At least the region eu-central-1 does not support Signature Version 2.
At http://docs.aws.amazon.com/ElasticLoadBalancing/latest/APIReference/using-query-api.html is stated that newer applications should support Version 4 as the standard signing.
See Amazon ELB Docs.

Status

  • done, ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)

paepke added some commits May 27, 2016

amazon suggests using signature_version 4 for accessing the elasticlo…
…adbalancing api. Currently at least eu-central-1 requires using this version in my case.
@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami May 27, 2016

Member

Thanks.

The change looks good to me - did you also had a chance to test it against the live API?

Member

Kami commented May 27, 2016

Thanks.

The change looks good to me - did you also had a chance to test it against the live API?

@paepke

This comment has been minimized.

Show comment
Hide comment
@paepke

paepke May 27, 2016

Contributor

I'm using it currently against the live api. Without this patch the ELB API is broken to me for eu-central-1.
Also eg. us-east-1 is working with this patch.

Contributor

paepke commented May 27, 2016

I'm using it currently against the live api. Without this patch the ELB API is broken to me for eu-central-1.
Also eg. us-east-1 is working with this patch.

@asfgit asfgit closed this in 323473e May 28, 2016

asfgit pushed a commit that referenced this pull request May 28, 2016

pep8 - new line at end of file
Closes #796

Signed-off-by: Tomaz Muraus <tomaz@tomaz.me>
@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami May 28, 2016

Member

Merged, thanks!

Member

Kami commented May 28, 2016

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment