Indicate listener ip #818
Closed
Indicate listener ip #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relaxdiego
added a commit
to DimensionDataResearch/ansible-dimensiondata
that referenced
this pull request
Jun 17, 2016
This change depends on apache/libcloud#818
The documentation for the Dimension Data Cloud REST API v2.2-20160222 states that a load balancer port can be an integer in the range of 1-65535 and, if not supplied, will be taken to mean 'Any Port'. This change fixes the libcloud driver to conform to the docs.
The documentation for the Dimension Data Cloud REST API v2.2-20160222 states that a load balancer can be statically assigned a listener IP on creation. This change fixes the dimension data driver to conform to the docs.
relaxdiego
force-pushed
the
indicate_listener_ip
branch
from
aa1a466 to
f2692cd
Compare
|
Big plus 1 on this one. |
|
👍 |
asfgit
pushed a commit
that referenced
this pull request
Jun 24, 2016
4 tasks
aimonb
pushed a commit
to DimensionDataResearch/ansible-modules-extras
that referenced
this pull request
Sep 8, 2016
* Allow setting of load balancer listener IP This change depends on apache/libcloud#818 * Use RawConfigParser instead of SafeConfigParser This change keeps get_credentials() from returning false when DIDATA_PASSWORD is a strong password that contains the '%' symbol. Before this change, getting an entry with that symbol would cause a ConfigParser.InterpolationSyntaxError which would cause the function to return false. The Ansible user would then get a confusion "User credentials not found" error. Since we don't expect the user to employ any string interpolation in this file, we might as well do away with it. * Print out a more helpful message when invalid credentials are provided. Before this change, Ansible would only print out '' as an error message because libcloud's InvalidCredentialsError type did not have a message attribute. This works around that problem by explicitly writing out a more helpful message when the above exception is caught.
relaxdiego
added a commit
to DimensionDataResearch/ansible-modules-extras
that referenced
this pull request
Sep 15, 2016
* Allow setting of load balancer listener IP This change depends on apache/libcloud#818 * Use RawConfigParser instead of SafeConfigParser This change keeps get_credentials() from returning false when DIDATA_PASSWORD is a strong password that contains the '%' symbol. Before this change, getting an entry with that symbol would cause a ConfigParser.InterpolationSyntaxError which would cause the function to return false. The Ansible user would then get a confusion "User credentials not found" error. Since we don't expect the user to employ any string interpolation in this file, we might as well do away with it. * Print out a more helpful message when invalid credentials are provided. Before this change, Ansible would only print out '' as an error message because libcloud's InvalidCredentialsError type did not have a message attribute. This works around that problem by explicitly writing out a more helpful message when the above exception is caught.
relaxdiego
added a commit
to DimensionDataResearch/ansible-modules-extras
that referenced
this pull request
Sep 15, 2016
* Allow setting of load balancer listener IP This change depends on apache/libcloud#818 * Use RawConfigParser instead of SafeConfigParser This change keeps get_credentials() from returning false when DIDATA_PASSWORD is a strong password that contains the '%' symbol. Before this change, getting an entry with that symbol would cause a ConfigParser.InterpolationSyntaxError which would cause the function to return false. The Ansible user would then get a confusion "User credentials not found" error. Since we don't expect the user to employ any string interpolation in this file, we might as well do away with it. * Print out a more helpful message when invalid credentials are provided. Before this change, Ansible would only print out '' as an error message because libcloud's InvalidCredentialsError type did not have a message attribute. This works around that problem by explicitly writing out a more helpful message when the above exception is caught.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a replacement of PR #815
The documentation for the Dimension Data Cloud REST API v2.2-20160222 states that a load balancer can be statically assigned a listener IP on creation. This change fixes the dimension data driver to conform to the docs.
Note that one of the commits (sha f06464a) is part of PR #817
Status
Checklist (tick everything that applies)