New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate listener ip #818

Closed
wants to merge 2 commits into
base: trunk
from

Conversation

Projects
None yet
3 participants
@relaxdiego
Contributor

relaxdiego commented Jun 17, 2016

Description

This is a replacement of PR #815

The documentation for the Dimension Data Cloud REST API v2.2-20160222 states that a load balancer can be statically assigned a listener IP on creation. This change fixes the dimension data driver to conform to the docs.

Note that one of the commits (sha f06464a) is part of PR #817

Status

  • done, ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)

relaxdiego added a commit to DimensionDataResearch/ansible-dimensiondata that referenced this pull request Jun 17, 2016

relaxdiego added some commits Jun 17, 2016

Allow setting of load balancer port to None
The documentation for the Dimension Data Cloud REST API v2.2-20160222
states that a load balancer port can be an integer in the range of
1-65535 and, if not supplied, will be taken to mean 'Any Port'. This
change fixes the libcloud driver to conform to the docs.
Allow setting of load balancer listener IP
The documentation for the Dimension Data Cloud REST API v2.2-20160222
states that a load balancer can be statically assigned a listener IP
on creation. This change fixes the dimension data driver to conform
to the docs.
@aimonb

This comment has been minimized.

Show comment
Hide comment
@aimonb

aimonb Jun 22, 2016

Contributor

Big plus 1 on this one.

Contributor

aimonb commented Jun 22, 2016

Big plus 1 on this one.

@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney

tonybaloney Jun 24, 2016

Contributor

👍

Contributor

tonybaloney commented Jun 24, 2016

👍

@asfgit asfgit closed this in 2d9f438 Jun 24, 2016

asfgit pushed a commit that referenced this pull request Jun 24, 2016

@relaxdiego relaxdiego referenced this pull request Jun 27, 2016

Closed

Allow setting of load balancer port to None #817

3 of 4 tasks complete

aimonb added a commit to DimensionDataResearch/ansible-modules-extras that referenced this pull request Sep 8, 2016

Multiple fixes (Details in the description) (#35)
* Allow setting of load balancer listener IP

This change depends on apache/libcloud#818

* Use RawConfigParser instead of SafeConfigParser

This change keeps get_credentials() from returning false when
DIDATA_PASSWORD is a strong password that contains the '%' symbol.
Before this change, getting an entry with that symbol would cause
a ConfigParser.InterpolationSyntaxError which would cause the function
to return false. The Ansible user would then get a confusion "User
credentials not found" error. Since we don't expect the user to employ
any string interpolation in this file, we might as well do away with it.

* Print out a more helpful message when invalid credentials are provided.

Before this change, Ansible would only print out '' as an error message
because libcloud's InvalidCredentialsError type did not have a message
attribute. This works around that problem by explicitly writing out a
more helpful message when the above exception is caught.

relaxdiego added a commit to DimensionDataResearch/ansible-modules-extras that referenced this pull request Sep 15, 2016

Multiple fixes (Details in the description) (#35)
* Allow setting of load balancer listener IP

This change depends on apache/libcloud#818

* Use RawConfigParser instead of SafeConfigParser

This change keeps get_credentials() from returning false when
DIDATA_PASSWORD is a strong password that contains the '%' symbol.
Before this change, getting an entry with that symbol would cause
a ConfigParser.InterpolationSyntaxError which would cause the function
to return false. The Ansible user would then get a confusion "User
credentials not found" error. Since we don't expect the user to employ
any string interpolation in this file, we might as well do away with it.

* Print out a more helpful message when invalid credentials are provided.

Before this change, Ansible would only print out '' as an error message
because libcloud's InvalidCredentialsError type did not have a message
attribute. This works around that problem by explicitly writing out a
more helpful message when the above exception is caught.

relaxdiego added a commit to DimensionDataResearch/ansible-modules-extras that referenced this pull request Sep 15, 2016

Multiple fixes (Details in the description) (#35)
* Allow setting of load balancer listener IP

This change depends on apache/libcloud#818

* Use RawConfigParser instead of SafeConfigParser

This change keeps get_credentials() from returning false when
DIDATA_PASSWORD is a strong password that contains the '%' symbol.
Before this change, getting an entry with that symbol would cause
a ConfigParser.InterpolationSyntaxError which would cause the function
to return false. The Ansible user would then get a confusion "User
credentials not found" error. Since we don't expect the user to employ
any string interpolation in this file, we might as well do away with it.

* Print out a more helpful message when invalid credentials are provided.

Before this change, Ansible would only print out '' as an error message
because libcloud's InvalidCredentialsError type did not have a message
attribute. This works around that problem by explicitly writing out a
more helpful message when the above exception is caught.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment