New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIBCLOUD-606 Can not connect to AWS with IAM role temporary credentials #820

Closed
wants to merge 5 commits into
base: trunk
from

Conversation

Projects
None yet
3 participants
@alejandrogr
Contributor

alejandrogr commented Jun 21, 2016

Connect to AWS using temporary IAM role credentials

Description

Can not connect to AWS with IAM role temporary credentials. Doesn't seem like the supplied token is in the header

From: LIBCLOUD-606

Status

done, ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)
@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney

tonybaloney Jun 24, 2016

Contributor

hi @alejandrogr thanks for the contribution, if you look at the test runs, every class that derived from this connection class (and didn't create a property self.token) is failing.

could you please add a supporting test for this scenario as well, the docs say that this is supported, so is this a bugfix or a new behaviour? http://libcloud.readthedocs.io/en/latest/compute/drivers/ec2.html#using-temporary-security-credentials

Contributor

tonybaloney commented Jun 24, 2016

hi @alejandrogr thanks for the contribution, if you look at the test runs, every class that derived from this connection class (and didn't create a property self.token) is failing.

could you please add a supporting test for this scenario as well, the docs say that this is supported, so is this a bugfix or a new behaviour? http://libcloud.readthedocs.io/en/latest/compute/drivers/ec2.html#using-temporary-security-credentials

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Jun 26, 2016

Member

Good catch - thanks!

And yeah, what Anthony said wrt tests :)

Member

Kami commented Jun 26, 2016

Good catch - thanks!

And yeah, what Anthony said wrt tests :)

@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney

tonybaloney Jun 30, 2016

Contributor

@alejandrogr can you run flake8 --ignore=E402 --exclude=test libcloud/ locally and just check the linting errors please? Travis is giving a failure.

Contributor

tonybaloney commented Jun 30, 2016

@alejandrogr can you run flake8 --ignore=E402 --exclude=test libcloud/ locally and just check the linting errors please? Travis is giving a failure.

@alejandrogr

This comment has been minimized.

Show comment
Hide comment
@alejandrogr

alejandrogr Jun 30, 2016

Contributor

Hi,

I've just checked the linting problems and solved them. I'm pretty new to python and libcloud so please let me know if something can be improved.

Should other derived drivers from BaseEC2NodeDriver supports the temporary token too?

Cheers

Contributor

alejandrogr commented Jun 30, 2016

Hi,

I've just checked the linting problems and solved them. I'm pretty new to python and libcloud so please let me know if something can be improved.

Should other derived drivers from BaseEC2NodeDriver supports the temporary token too?

Cheers

@asfgit asfgit closed this in 1ac00c7 Jul 2, 2016

asfgit pushed a commit that referenced this pull request Jul 2, 2016

fix(): check attribute token exists in BaseEC2NodeDriver
Closes #820

Signed-off-by: Tomaz Muraus <tomaz@tomaz.me>

asfgit pushed a commit that referenced this pull request Jul 2, 2016

add tests for temporary token support on EC2NodeDriver
Closes #820

Signed-off-by: Tomaz Muraus <tomaz@tomaz.me>

asfgit pushed a commit that referenced this pull request Jul 2, 2016

fix(): miltiple spaces after keyword
Closes #820

Signed-off-by: Tomaz Muraus <tomaz@tomaz.me>

asfgit pushed a commit that referenced this pull request Jul 2, 2016

remove unnecesary blank lines in test
Closes #820

Signed-off-by: Tomaz Muraus <tomaz@tomaz.me>
@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Jul 2, 2016

Member

Merged into trunk, thanks.

For now, I think it's the best to only support token in the EC2 driver since I believe it's EC2-specific functionality.

Member

Kami commented Jul 2, 2016

Merged into trunk, thanks.

For now, I think it's the best to only support token in the EC2 driver since I believe it's EC2-specific functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment