Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libvirt/lookup node by uuid or by name #823

Closed
wants to merge 2 commits into from
Closed

Conversation

wuyuewen
Copy link

@wuyuewen wuyuewen commented Jun 24, 2016

Libvirt/lookup node by uuid or by name

Description

Currently for libvirt driver, there is no API to get a node by node's uuid or name, so I added ex_get_node_by_uuid and ex_get_node_by_name function and functions it calls to support return the specific node.

Status

  • done, ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)

@wuyuewen wuyuewen force-pushed the trunk branch 3 times, most recently from 339e42f to 3eb20fe Compare June 24, 2016 09:05
Signed-off-by: wuyuewen <suhupt_f@126.com>

Update libvrit_driver.py

Signed-off-by: wuyuewen <suhupt_f@126.com>

Update libvirt_driver.py

Signed-off-by: wuyuewen <suhupt_f@126.com>

Update libvirt_driver.py

Signed-off-by: wuyuewen <suhupt_f@126.com>

tox check

Signed-off-by: wuyuewen <suhupt_f@126.com>

tox check

Signed-off-by: wuyuewen <suhupt_f@126.com>
"""
Retrieve Node object for a domain with a provided uuid.

:type uuid: ``str``
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a :param docstring statement

Signed-off-by: wuyuewen <suhupt_f@126.com>
@tonybaloney
Copy link
Contributor

ok, 👍

@asfgit asfgit closed this in 142ab8d Jun 25, 2016
asfgit pushed a commit that referenced this pull request Jun 25, 2016
asfgit pushed a commit that referenced this pull request Jun 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants