Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libvirt/lookup node by uuid or by name #823

Closed
wants to merge 2 commits into from
Closed

Conversation

@wuyuewen
Copy link

@wuyuewen wuyuewen commented Jun 24, 2016

Libvirt/lookup node by uuid or by name

Description

Currently for libvirt driver, there is no API to get a node by node's uuid or name, so I added ex_get_node_by_uuid and ex_get_node_by_name function and functions it calls to support return the specific node.

Status

  • done, ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)
@wuyuewen wuyuewen force-pushed the wuyuewen:trunk branch 3 times, most recently from 339e42f to 3eb20fe Jun 24, 2016
Signed-off-by: wuyuewen <suhupt_f@126.com>

Update libvrit_driver.py

Signed-off-by: wuyuewen <suhupt_f@126.com>

Update libvirt_driver.py

Signed-off-by: wuyuewen <suhupt_f@126.com>

Update libvirt_driver.py

Signed-off-by: wuyuewen <suhupt_f@126.com>

tox check

Signed-off-by: wuyuewen <suhupt_f@126.com>

tox check

Signed-off-by: wuyuewen <suhupt_f@126.com>
@wuyuewen wuyuewen force-pushed the wuyuewen:trunk branch from 3eb20fe to ee10990 Jun 24, 2016
"""
Retrieve Node object for a domain with a provided uuid.
:type uuid: ``str``

This comment has been minimized.

@tonybaloney

tonybaloney Jun 24, 2016
Contributor

please add a :param docstring statement

"""
Retrieve Node object for a domain with a provided name.
:type name: ``str``

This comment has been minimized.

@tonybaloney

tonybaloney Jun 24, 2016
Contributor

likewise

Signed-off-by: wuyuewen <suhupt_f@126.com>
@tonybaloney
Copy link
Contributor

@tonybaloney tonybaloney commented Jun 25, 2016

ok, 👍

@asfgit asfgit closed this in 142ab8d Jun 25, 2016
asfgit pushed a commit that referenced this pull request Jun 25, 2016
asfgit pushed a commit that referenced this pull request Jun 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.