Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added forceCustomization option for vCloud Director #824

Merged
merged 9 commits into from Jun 25, 2016

Conversation

juanfont
Copy link
Contributor

Added forceCustomization option for vCloud Director

Description

These commits add support for forceCustomization param when deploying a node in vCloud Director.

See https://www.vmware.com/support/vcd/doc/rest-api-doc-1.5-html/types/DeployVAppParamsType.html.

Status

Ready for review.

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)

@tonybaloney
Copy link
Contributor

Great contribution, thanks @juanfont 👍

@@ -1044,8 +1063,6 @@ def ex_deploy_node(self, node):
method='POST',
headers=headers)
self._wait_for_task_completion(res.object.get('href'))
res = self.connection.request(get_url_path(node.id))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intentional and desired that this function doesn't return anything now?

Or did I miss something?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's intentional. That's an internal method that handles both vapp's and vm's. It's meant to be called only from ex_deploy_node (where the node is indeed returned).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry, I was confused by the diff (I didn't fully expand it so I thought it's part of the public method).

@asfgit asfgit merged commit c1da02c into apache:trunk Jun 25, 2016
asfgit pushed a commit that referenced this pull request Jun 25, 2016
@Kami
Copy link
Member

Kami commented Jun 25, 2016

Merged, thanks!

asfgit pushed a commit that referenced this pull request Jun 25, 2016
asfgit pushed a commit that referenced this pull request Jun 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants