Added forceCustomization option for vCloud Director #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow the coding standards better by using a strict comparison to None.
|
Great contribution, thanks @juanfont |
| @@ -1044,8 +1063,6 @@ def ex_deploy_node(self, node): | |||
| method='POST', | |||
| headers=headers) | |||
| self._wait_for_task_completion(res.object.get('href')) | |||
| res = self.connection.request(get_url_path(node.id)) | |||
There was a problem hiding this comment.
Is it intentional and desired that this function doesn't return anything now?
Or did I miss something?
There was a problem hiding this comment.
It's intentional. That's an internal method that handles both vapp's and vm's. It's meant to be called only from ex_deploy_node (where the node is indeed returned).
There was a problem hiding this comment.
Ah, sorry, I was confused by the diff (I didn't fully expand it so I thought it's part of the public method).
asfgit
pushed a commit
that referenced
this pull request
Jun 25, 2016
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Added forceCustomization option for vCloud Director
Description
These commits add support for forceCustomization param when deploying a node in vCloud Director.
See https://www.vmware.com/support/vcd/doc/rest-api-doc-1.5-html/types/DeployVAppParamsType.html.
Status
Ready for review.
Checklist (tick everything that applies)