Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdded forceCustomization option for vCloud Director #824
Conversation
juanfont
added some commits
Dec 10, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Great contribution, thanks @juanfont |
Kami
reviewed
Jun 25, 2016
| @@ -1044,8 +1063,6 @@ def ex_deploy_node(self, node): | ||
| method='POST', | ||
| headers=headers) | ||
| self._wait_for_task_completion(res.object.get('href')) | ||
| res = self.connection.request(get_url_path(node.id)) |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Kami
Jun 25, 2016
Member
Is it intentional and desired that this function doesn't return anything now?
Or did I miss something?
Kami
Jun 25, 2016
Member
Is it intentional and desired that this function doesn't return anything now?
Or did I miss something?
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
juanfont
Jun 25, 2016
Contributor
It's intentional. That's an internal method that handles both vapp's and vm's. It's meant to be called only from ex_deploy_node (where the node is indeed returned).
juanfont
Jun 25, 2016
Contributor
It's intentional. That's an internal method that handles both vapp's and vm's. It's meant to be called only from ex_deploy_node (where the node is indeed returned).
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Kami
Jun 25, 2016
Member
Ah, sorry, I was confused by the diff (I didn't fully expand it so I thought it's part of the public method).
Kami
Jun 25, 2016
Member
Ah, sorry, I was confused by the diff (I didn't fully expand it so I thought it's part of the public method).
asfgit
merged commit c1da02c
into
apache:trunk
Jun 25, 2016
1 check passed
pushed a commit
that referenced
this pull request
Jun 25, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Merged, thanks! |
pushed a commit
that referenced
this pull request
Jun 25, 2016
pushed a commit
that referenced
this pull request
Jun 25, 2016
juanfont commentedJun 24, 2016
Added forceCustomization option for vCloud Director
Description
These commits add support for forceCustomization param when deploying a node in vCloud Director.
See https://www.vmware.com/support/vcd/doc/rest-api-doc-1.5-html/types/DeployVAppParamsType.html.
Status
Ready for review.
Checklist (tick everything that applies)