Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdded forceCustomization option for vCloud Director #824
Conversation
|
Great contribution, thanks @juanfont |
| @@ -1044,8 +1063,6 @@ def ex_deploy_node(self, node): | |||
| method='POST', | |||
| headers=headers) | |||
| self._wait_for_task_completion(res.object.get('href')) | |||
| res = self.connection.request(get_url_path(node.id)) | |||
This comment has been minimized.
This comment has been minimized.
Kami
Jun 25, 2016
Member
Is it intentional and desired that this function doesn't return anything now?
Or did I miss something?
This comment has been minimized.
This comment has been minimized.
juanfont
Jun 25, 2016
Author
Contributor
It's intentional. That's an internal method that handles both vapp's and vm's. It's meant to be called only from ex_deploy_node (where the node is indeed returned).
This comment has been minimized.
This comment has been minimized.
Kami
Jun 25, 2016
Member
Ah, sorry, I was confused by the diff (I didn't fully expand it so I thought it's part of the public method).
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
juanfont commentedJun 24, 2016
Added forceCustomization option for vCloud Director
Description
These commits add support for forceCustomization param when deploying a node in vCloud Director.
See https://www.vmware.com/support/vcd/doc/rest-api-doc-1.5-html/types/DeployVAppParamsType.html.
Status
Ready for review.
Checklist (tick everything that applies)