New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libcloud support for image guest os features. #825

Closed
wants to merge 2 commits into
base: trunk
from

Conversation

Projects
None yet
3 participants
@illfelder
Contributor

illfelder commented Jun 25, 2016

Image "guestOsFeature" support during image copy and creation.

Description

We are introducing a new optional property on the image resource known as "guestOsFeature". The feature is available in the alpha API and is needed to optimize virtual machine settings during instance creation. The only value currently supported (if specified) is "VIRTIO_SCSI_MULTIQUEUE".

Status

Done, ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)
@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney
Contributor

tonybaloney commented Jun 25, 2016

@supertom

This comment has been minimized.

Show comment
Hide comment
@supertom

supertom Jun 27, 2016

Contributor

LGTM, couple of spelling errors I noted.

Contributor

supertom commented Jun 27, 2016

LGTM, couple of spelling errors I noted.

@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney

tonybaloney Jun 28, 2016

Contributor

@illfelder 1 typo to correct and please also improve the test scenario to validate the outgoing payload.

Contributor

tonybaloney commented Jun 28, 2016

@illfelder 1 typo to correct and please also improve the test scenario to validate the outgoing payload.

Add libcloud support for image guest OS features.
Guest OS features are a repeated field in the API.
@illfelder

This comment has been minimized.

Show comment
Hide comment
@illfelder

illfelder Jun 29, 2016

Contributor

Added testing to validate the request is getting created properly. I also fixed a comment about the type of guest_os_features when creating an image.

Contributor

illfelder commented Jun 29, 2016

Added testing to validate the request is getting created properly. I also fixed a comment about the type of guest_os_features when creating an image.

@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney

tonybaloney Jun 29, 2016

Contributor

@illfelder think you broke the build with the extra commit :-)

Contributor

tonybaloney commented Jun 29, 2016

@illfelder think you broke the build with the extra commit :-)

@illfelder

This comment has been minimized.

Show comment
Hide comment
@illfelder

illfelder Jun 29, 2016

Contributor

Yup, fixed the linter issue. Should be good now whenever travis next runs.

Contributor

illfelder commented Jun 29, 2016

Yup, fixed the linter issue. Should be good now whenever travis next runs.

@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney

tonybaloney Jun 29, 2016

Contributor

OK 👍

Contributor

tonybaloney commented Jun 29, 2016

OK 👍

@asfgit asfgit closed this in 370c749 Jun 29, 2016

asfgit pushed a commit that referenced this pull request Jun 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment