Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libcloud support for image guest os features. #825

Closed
wants to merge 2 commits into from

Conversation

@illfelder
Copy link
Contributor

@illfelder illfelder commented Jun 25, 2016

Image "guestOsFeature" support during image copy and creation.

Description

We are introducing a new optional property on the image resource known as "guestOsFeature". The feature is available in the alpha API and is needed to optimize virtual machine settings during instance creation. The only value currently supported (if specified) is "VIRTIO_SCSI_MULTIQUEUE".

Status

Done, ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)
@tonybaloney
Copy link
Contributor

@tonybaloney tonybaloney commented Jun 25, 2016

@@ -4752,29 +4753,31 @@ def ex_copy_image(self, name, url, description=None, family=None,
:param family: The family of the image
:type family: ``str``
:param guest_os_feature: The features of the guest opertaing system.
:type guest_os_feature: ``str``
:param guest_os_features: The features of the guest opertaing system.

This comment has been minimized.

@supertom

supertom Jun 27, 2016
Contributor

"operating"

This comment has been minimized.

@illfelder

illfelder Jun 27, 2016
Author Contributor

Thanks!

values include \'VIRTIO_SCSI_MULTIQUEUE\'
if specified.
:type guest_os_feature: ``str``
:keywork guest_os_features: Features of the guest opertaing system,

This comment has been minimized.

@supertom

supertom Jun 27, 2016
Contributor

"operating"

@illfelder illfelder force-pushed the illfelder:trunk branch from 9585eb0 to 0f57f3a Jun 27, 2016
@supertom
Copy link
Contributor

@supertom supertom commented Jun 27, 2016

LGTM, couple of spelling errors I noted.

@illfelder illfelder force-pushed the illfelder:trunk branch from 0f57f3a to 4588670 Jun 27, 2016
if guest_os_features:
image_data['guestOsFeatures'] = []
for feature in guest_os_features:
if feature in possble_features:

This comment has been minimized.

@tonybaloney

tonybaloney Jun 28, 2016
Contributor

that should be for feature in possible_features: and also showing this case needs a test :-)

This comment has been minimized.

@illfelder

illfelder Jun 28, 2016
Author Contributor

Yup, thanks for the note. I missed the typo (and failing test) when I refactored some of the code).

@tonybaloney
Copy link
Contributor

@tonybaloney tonybaloney commented Jun 28, 2016

@illfelder 1 typo to correct and please also improve the test scenario to validate the outgoing payload.

Guest OS features are a repeated field in the API.
@illfelder illfelder force-pushed the illfelder:trunk branch from 4588670 to 98e56d6 Jun 28, 2016
@illfelder
Copy link
Contributor Author

@illfelder illfelder commented Jun 29, 2016

Added testing to validate the request is getting created properly. I also fixed a comment about the type of guest_os_features when creating an image.

@tonybaloney
Copy link
Contributor

@tonybaloney tonybaloney commented Jun 29, 2016

@illfelder think you broke the build with the extra commit :-)

@illfelder illfelder force-pushed the illfelder:trunk branch from 6fb25b9 to 916d6b1 Jun 29, 2016
@illfelder
Copy link
Contributor Author

@illfelder illfelder commented Jun 29, 2016

Yup, fixed the linter issue. Should be good now whenever travis next runs.

@tonybaloney
Copy link
Contributor

@tonybaloney tonybaloney commented Jun 29, 2016

OK 👍

@asfgit asfgit closed this in 370c749 Jun 29, 2016
asfgit pushed a commit that referenced this pull request Jun 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.