New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aliyun ecs: support listing security group attributes #826

Closed
wants to merge 3 commits into
base: trunk
from

Conversation

Projects
None yet
2 participants
@net613
Contributor

net613 commented Jun 25, 2016

Aliyun ecs: support listing security group attributes

Description

Currently for Aliyun ECS, you cannot list security group attributes through ecs deriver.
That means you have to login in to check user's authorization.
For example, users only from 192.168.1.1-192.168.1.100 can access the specified VM.

Status

  • work in progress
  • done, ready for review

@see Aliyun-ECS-API-Reference: http://pan.baidu.com/s/1gfnYBhL

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Jun 25, 2016

Member

Thanks, the changes look good to me 👍

Can you please also sign an ICLA if you haven't already (https://libcloud.readthedocs.io/en/latest/development.html#contributing-bigger-changes)?

Member

Kami commented Jun 25, 2016

Thanks, the changes look good to me 👍

Can you please also sign an ICLA if you haven't already (https://libcloud.readthedocs.io/en/latest/development.html#contributing-bigger-changes)?

@net613

This comment has been minimized.

Show comment
Hide comment
@net613

net613 Jun 25, 2016

Contributor

Thanks, @Kami . I have just sent my signed ICLA to secretary@apache.org

Contributor

net613 commented Jun 25, 2016

Thanks, @Kami . I have just sent my signed ICLA to secretary@apache.org

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Jun 25, 2016

Member

I can confirm we have received an ICLA - thanks.

Member

Kami commented Jun 25, 2016

I can confirm we have received an ICLA - thanks.

@asfgit asfgit closed this in 127c3b8 Jun 25, 2016

asfgit pushed a commit that referenced this pull request Jun 25, 2016

ecs_support_list_security_group_attributes
Closes #826

Signed-off-by: Tomaz Muraus <tomaz@tomaz.me>
@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Jun 25, 2016

Member

Merged, thanks!

Member

Kami commented Jun 25, 2016

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment