New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIBCLOUD-830 Adding S3 support for cn-north-1 #827

Closed
wants to merge 1 commit into
base: trunk
from

Conversation

Projects
None yet
2 participants
@JamieCressey
Contributor

JamieCressey commented Jun 29, 2016

Add S3 support for AWS China (cn-north-1)

Description

This PR adds S3 support for AWS China (cn-north-1)

Status

  • done, ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)
@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Jun 29, 2016

Member

Thanks for the contribution!

That's actually the old approach which has been mostly removed in v1.0.0 (we moved away from class per region to "region" constructor argument approach), but S3 is one of the drivers which still needs to be updated...

I will go ahead and merge this for now, but hopefully we can also update S3 driver soon and move it to the new model (then we can get rid of this code).

Member

Kami commented Jun 29, 2016

Thanks for the contribution!

That's actually the old approach which has been mostly removed in v1.0.0 (we moved away from class per region to "region" constructor argument approach), but S3 is one of the drivers which still needs to be updated...

I will go ahead and merge this for now, but hopefully we can also update S3 driver soon and move it to the new model (then we can get rid of this code).

@asfgit asfgit closed this in 6d3e601 Jun 29, 2016

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Jun 29, 2016

Member

Merged, thanks!

Member

Kami commented Jun 29, 2016

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment