New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docker] Add network_mode and label params to deploy_container #831

Closed
wants to merge 1 commit into
base: trunk
from

Conversation

Projects
None yet
2 participants
@JamieCressey
Contributor

JamieCressey commented Jul 3, 2016

Add network_mode and label params to deploy_container function within Docker driver

Description

This PR adds network_mode and label params to the deploy_container function within the Docker container driver. Labels are particularly useful for Swarm's (anti-)affinity rules. The previous and default behaviour should not be affected.

Status

  • done, ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)
@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney

tonybaloney Jul 5, 2016

Contributor

👍

Contributor

tonybaloney commented Jul 5, 2016

👍

@asfgit asfgit closed this in e147721 Jul 5, 2016

asfgit pushed a commit that referenced this pull request Jul 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment