New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added image details and size details to a node in dimension data driver #832

Closed
wants to merge 1 commit into
base: trunk
from

Conversation

Projects
None yet
2 participants
@tonybaloney
Contributor

tonybaloney commented Jul 4, 2016

Status

Replace this: describe the PR status. Examples:

  • done, ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)
@@ -2786,6 +2786,10 @@ def _to_node(self, element):
state=node_state,
public_ips=[public_ip] if public_ip is not None else [],
private_ips=[private_ip] if private_ip is not None else [],
size=self.list_sizes()[0],
image=NodeImage(extra['sourceImageId'],

This comment has been minimized.

@Kami

Kami Jul 10, 2016

Member

Just to confirm - those keys are always present in the extra dictionary, right?

@Kami

Kami Jul 10, 2016

Member

Just to confirm - those keys are always present in the extra dictionary, right?

This comment has been minimized.

@Kami

Kami Jul 10, 2016

Member

It would also make it a bit easier to read / fail safe if we use keyword arguments when calling a constructor, but that's not a blocker for me.

@Kami

Kami Jul 10, 2016

Member

It would also make it a bit easier to read / fail safe if we use keyword arguments when calling a constructor, but that's not a blocker for me.

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Jul 10, 2016

Member

LGTM, 👍

Member

Kami commented Jul 10, 2016

LGTM, 👍

@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney

tonybaloney Jul 14, 2016

Contributor

k, merging.

Contributor

tonybaloney commented Jul 14, 2016

k, merging.

@asfgit asfgit closed this in ae4f64e Jul 14, 2016

asfgit pushed a commit that referenced this pull request Jul 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment