added image details and size details to a node in dimension data driver #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2786,6 +2786,10 @@ def _to_node(self, element): | |||
| state=node_state, | |||
| public_ips=[public_ip] if public_ip is not None else [], | |||
| private_ips=[private_ip] if private_ip is not None else [], | |||
| size=self.list_sizes()[0], | |||
| image=NodeImage(extra['sourceImageId'], | |||
There was a problem hiding this comment.
Just to confirm - those keys are always present in the extra dictionary, right?
There was a problem hiding this comment.
It would also make it a bit easier to read / fail safe if we use keyword arguments when calling a constructor, but that's not a blocker for me.
|
LGTM, 👍 |
|
k, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Replace this: describe the PR status. Examples:
Checklist (tick everything that applies)