Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for setting the VM admin password from vCloud #833

Closed
wants to merge 5 commits into from

Conversation

@juanfont
Copy link
Contributor

@juanfont juanfont commented Jul 4, 2016

Add support for setting the VM admin password from vCloud

Description

These commits allow the user to establish the admin password of a virtual machine on its creation without having to connect to it. It uses the API provided by VMware and its VMware Tools.

Status

Done and ready for review.

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)
res.object.insert(i, e)
return res

def _change_vm_admin_password(self, vapp_or_vm_id, ex_admin_password):

This comment has been minimized.

@tonybaloney

tonybaloney Jul 4, 2016
Contributor

do you not think this might be a function that users might want to call publically? If so I would rename it ex_change_vm_admin_password

@juanfont
Copy link
Contributor Author

@juanfont juanfont commented Jul 5, 2016

Yes, you are right :)

@tonybaloney
Copy link
Contributor

@tonybaloney tonybaloney commented Jul 5, 2016

thanks 👍

@asfgit asfgit closed this in 5430cd2 Jul 5, 2016
asfgit pushed a commit that referenced this pull request Jul 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.