Add support for setting the VM admin password from vCloud #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| res.object.insert(i, e) | ||
| return res | ||
|
|
||
| def _change_vm_admin_password(self, vapp_or_vm_id, ex_admin_password): |
There was a problem hiding this comment.
do you not think this might be a function that users might want to call publically? If so I would rename it ex_change_vm_admin_password
|
Yes, you are right :) |
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Add support for setting the VM admin password from vCloud
Description
These commits allow the user to establish the admin password of a virtual machine on its creation without having to connect to it. It uses the API provided by VMware and its VMware Tools.
Status
Done and ready for review.
Checklist (tick everything that applies)