auroradns: Change valid record types and implement listing #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the supported record types by Aurora DNS and it also supports listing the valid record types. It merely returns the keys of the RECORD_TYPE_MAP dict which is already available. In the future Aurora DNS should return this in a API call so this is no longer a static dictionary. This dict also contained a type 'SPF', which is not valid. SPF records are defined as TXT records in DNS. Remove this from the list of valid record types. Further it adds support for the SSHFP, DS, TLSA and PTR type since they are also supported. Also add tests to verify if this functions returns the proper values
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the supported record types by Aurora DNS and it also
supports listing the valid record types.
It merely returns the keys of the RECORD_TYPE_MAP dict which is already
available. In the future Aurora DNS should return this in a API call
so this is no longer a static dictionary.
This dict also contained a type 'SPF', which is not valid. SPF records
are defined as TXT records in DNS. Remove this from the list of valid
record types.
Further it adds support for the SSHFP, DS, TLSA and PTR type since
they are also supported.
Also add tests to verify if this functions returns the proper values