[LIBCLOUD-833] and [LIBCLOUD-834](workaround) #839
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 11, 2016 13:43
…eds" error. Disabled the upload using mutlipart uploads. Disabled upload_object_via_stream from using multipart uploads which allows V4 Auth uploads to complete.
|
@lmorfitt I think you introduced some spacing errors that are failing the linter. |
…ng (80 > 79 characters)"
|
@tonybaloney - Thanks. Fixed it up. Luke |
|
k, LGTM 👍 |
| url=None, timeout=None, proxy_url=None, token=None, | ||
| retry_delay=None, backoff=None): | ||
| super(S3CNNorthConnection, self).__init__( | ||
| user_id, key, secure, host, |
There was a problem hiding this comment.
Minor thing - please use keyword arguments when calling a method (user_id=user_id, key=key, etc.). It makes code less error prone (now it's easy to accidentally break it if the argument order changes or similar).
|
@Kami - Thank you for the note. I copied the existing code for S3APNE2Connection so incorrectly assumed this code was supported. If I get chance I will go back and update both to support kwargs. thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Title (replace this with a logical title for your changes)
Description
[LIBCLOUD-833] - The AWS China region requires V4 authentication. Set the auth version to v4 allowing the region to function.
LIBCLOUD-834 - With V4 auth enabled the upload_via_stream function does not work and fails with an "InvalidCreds" error. This work around disables the supports_s3_multipart_upload section allow files to be uploaded to V4 regions.
For more information on contributing, please see Contributing
section of our documentation.
Status
Replace this: describe the PR status. Examples:
Checklist (tick everything that applies)