New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIBCLOUD-833] and [LIBCLOUD-834](workaround) #839

Closed
wants to merge 3 commits into
base: trunk
from

Conversation

Projects
None yet
3 participants
@lmorfitt

lmorfitt commented Jul 11, 2016

Changes Title (replace this with a logical title for your changes)

Description

[LIBCLOUD-833] - The AWS China region requires V4 authentication. Set the auth version to v4 allowing the region to function.

LIBCLOUD-834 - With V4 auth enabled the upload_via_stream function does not work and fails with an "InvalidCreds" error. This work around disables the supports_s3_multipart_upload section allow files to be uploaded to V4 regions.

For more information on contributing, please see Contributing
section of our documentation.

Status

Replace this: describe the PR status. Examples:

  • ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)

Luke Morfitt added some commits Jul 11, 2016

Luke Morfitt Luke Morfitt
V4 authenticaion and multipart_upload currently fails with "InvalidCr…
…eds" error. Disabled the upload using mutlipart uploads. Disabled upload_object_via_stream from using multipart uploads which allows V4 Auth uploads to complete.
@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney

tonybaloney Jul 14, 2016

Contributor

@lmorfitt I think you introduced some spacing errors that are failing the linter.

Contributor

tonybaloney commented Jul 14, 2016

@lmorfitt I think you introduced some spacing errors that are failing the linter.

@lmorfitt

This comment has been minimized.

Show comment
Hide comment
@lmorfitt

lmorfitt Jul 15, 2016

@tonybaloney - Thanks. Fixed it up.

Luke

lmorfitt commented Jul 15, 2016

@tonybaloney - Thanks. Fixed it up.

Luke

@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney

tonybaloney Jul 16, 2016

Contributor

k, LGTM 👍

Contributor

tonybaloney commented Jul 16, 2016

k, LGTM 👍

@asfgit asfgit closed this in f01da6c Jul 16, 2016

asfgit pushed a commit that referenced this pull request Jul 16, 2016

url=None, timeout=None, proxy_url=None, token=None,
retry_delay=None, backoff=None):
super(S3CNNorthConnection, self).__init__(
user_id, key, secure, host,

This comment has been minimized.

@Kami

Kami Jul 17, 2016

Member

Minor thing - please use keyword arguments when calling a method (user_id=user_id, key=key, etc.). It makes code less error prone (now it's easy to accidentally break it if the argument order changes or similar).

@Kami

Kami Jul 17, 2016

Member

Minor thing - please use keyword arguments when calling a method (user_id=user_id, key=key, etc.). It makes code less error prone (now it's easy to accidentally break it if the argument order changes or similar).

@lmorfitt

This comment has been minimized.

Show comment
Hide comment
@lmorfitt

lmorfitt Jul 18, 2016

@Kami - Thank you for the note.

I copied the existing code for S3APNE2Connection so incorrectly assumed this code was supported.

If I get chance I will go back and update both to support kwargs.

thanks
Luke

lmorfitt commented Jul 18, 2016

@Kami - Thank you for the note.

I copied the existing code for S3APNE2Connection so incorrectly assumed this code was supported.

If I get chance I will go back and update both to support kwargs.

thanks
Luke

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment