[LIBCLOUD-836] Support Abiquo 3.4, remove deprecated attrs from VM model #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 @lochiiconnectivity , this does highlight the abuse of **kwargs in this driver though. Feel free to submit a seperate PR refactoring this :-) |
|
you know what, I've only just realised that @lochiiconnectivity is THE David Freedman. Hey Dave! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support Abiquo 3.4, remove deprecated attrs from VM model
Description
As per JIRA, VM Model prior to Abiquo 3.4 specifies a size attribute 'hdInBytes', but this has not been used for some time (instead, HD size is automatically taken from the template), and it was deprecated from the VM model in 3.4 in favour of a disk node (see http://wiki.abiquo.com/display/ABI34/API+Changelog+v3.4)
Status
Checklist (tick everything that applies)