New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIBCLOUD-836] Support Abiquo 3.4, remove deprecated attrs from VM model #840

Closed
wants to merge 1 commit into
base: trunk
from

Conversation

Projects
None yet
2 participants
@lochiiconnectivity
Contributor

lochiiconnectivity commented Jul 13, 2016

Support Abiquo 3.4, remove deprecated attrs from VM model

Description

As per JIRA, VM Model prior to Abiquo 3.4 specifies a size attribute 'hdInBytes', but this has not been used for some time (instead, HD size is automatically taken from the template), and it was deprecated from the VM model in 3.4 in favour of a disk node (see http://wiki.abiquo.com/display/ABI34/API+Changelog+v3.4)

Status

  • done, ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)
@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney

tonybaloney Jul 14, 2016

Contributor

👍 @lochiiconnectivity , this does highlight the abuse of **kwargs in this driver though. Feel free to submit a seperate PR refactoring this :-)

Contributor

tonybaloney commented Jul 14, 2016

👍 @lochiiconnectivity , this does highlight the abuse of **kwargs in this driver though. Feel free to submit a seperate PR refactoring this :-)

@asfgit asfgit closed this in f04b568 Jul 14, 2016

asfgit pushed a commit that referenced this pull request Jul 14, 2016

@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney

tonybaloney Jul 14, 2016

Contributor

you know what, I've only just realised that @lochiiconnectivity is THE David Freedman. Hey Dave!

Contributor

tonybaloney commented Jul 14, 2016

you know what, I've only just realised that @lochiiconnectivity is THE David Freedman. Hey Dave!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment