[GCE] Support Managed Instance Groups#842
Closed
supertom wants to merge 1 commit intoapache:trunkfrom
Closed
Conversation
Contributor
|
Good work Tom. Do you have an ICLA signed btw? |
libcloud/compute/drivers/gce.py
Outdated
| :type size: ``str`` | ||
|
|
||
| :param zone: Zone to wich the Instance Group belongs | ||
| :type zone: ``str`` |
Contributor
There was a problem hiding this comment.
Consider also allowing GCEZone. Same with other methods.
Contributor
|
Small nit about allowing other param types, but otherwise LGTM! |
Contributor
Author
|
@tonybaloney I thought I did have an ICLA on file, but I didn't, so thanks for asking. It's now on file with Apache. |
Contributor
|
That's cool @supertom, I don't have access to check them. I won't ask again! |
… Groups in libcloud. The following methods have been added (with supporting classes). * gce.ex_get_instancetemplate(template) * gce.ex_list_instancetemplates() * gce.ex_get_instancegroupmgr(name, zone) * gce.ex_list_instancegroupmgrs() * gce.ex_create_instancegroupmgr(name, zone, template, size) * gce.ex_destroy_instancegroupmgr(instance_group) Basic AutoScaler support has also been added. Tests and fixtures have also been added. Some documentation, unrelated to this feature, has also been fixed.
cd7d591 to
6df8fe6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[GCE] Support for Managed Instance Groups
Description
This PR aims to add support for Managed Instance Groups (MIGs) on GCE. Basic support for AutoScalers has also been added.
The following methods have been added (with supporting classes).
(Some) Tests and fixtures have also been added.
Useful Links
Example Usage
Status
Checklist (tick everything that applies)