New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIBCLOUD-839] IAM temporary credentials token support for ElasticLBDriver #843

Closed
wants to merge 2 commits into
base: trunk
from

Conversation

Projects
None yet
2 participants
@lrvan
Contributor

lrvan commented Jul 22, 2016

Connect to AWS ELB using IAM role temporary credentials

Description

Current implementation of ElasticLBDriver driver doesn't support token parameter which is required for authentication using IAM temporary credentials.

Issue:
https://issues.apache.org/jira/browse/LIBCLOUD-839

Status

done, ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)
@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Jul 30, 2016

Member

Thanks for the contribution.

The change looks good to me.

Member

Kami commented Jul 30, 2016

Thanks for the contribution.

The change looks good to me.

@asfgit asfgit closed this in 2163e75 Jul 30, 2016

asfgit pushed a commit that referenced this pull request Jul 30, 2016

removed assertIn to fix test_driver_with_token_signature_version test…
… in python 2.6

Closes #843

Signed-off-by: Tomaz Muraus <tomaz@tomaz.me>
@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Jul 30, 2016

Member

Merged, thanks!

Member

Kami commented Jul 30, 2016

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment