[LIBCLOUD-843] Added fetch tags support in elb driver#848
Closed
lrvan wants to merge 2 commits intoapache:trunkfrom
Closed
[LIBCLOUD-843] Added fetch tags support in elb driver#848lrvan wants to merge 2 commits intoapache:trunkfrom
lrvan wants to merge 2 commits intoapache:trunkfrom
Conversation
libcloud/loadbalancer/base.py
Outdated
| raise NotImplementedError( | ||
| 'get_balancer not implemented for this driver') | ||
|
|
||
| def get_tags(self, balancer_id): |
Contributor
There was a problem hiding this comment.
would be better named list_balancer_tags, to be more consistent with the other base methods.
Contributor
|
thanks @lrvan for the contribution, I had a couple of questions (commented) about the method names and approach. |
…tags private extra
Contributor
|
Great. thanks 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fetch tags support in ELB driver
Description
Currently ELB driver doesn't provide a way to fetch tags for load balancer instance(s). Appropriate method calling DescribeTags AWS API action is implemented to address this.
Issue:
https://issues.apache.org/jira/browse/LIBCLOUD-843
Status
done, ready for review
Checklist (tick everything that applies)