New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIBCLOUD-843] Added fetch tags support in elb driver #848

Closed
wants to merge 2 commits into
base: trunk
from

Conversation

Projects
None yet
2 participants
@lrvan
Contributor

lrvan commented Aug 8, 2016

Fetch tags support in ELB driver

Description

Currently ELB driver doesn't provide a way to fetch tags for load balancer instance(s). Appropriate method calling DescribeTags AWS API action is implemented to address this.

Issue:
https://issues.apache.org/jira/browse/LIBCLOUD-843

Status

done, ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)
@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney

tonybaloney Aug 11, 2016

Contributor

thanks @lrvan for the contribution, I had a couple of questions (commented) about the method names and approach.

Contributor

tonybaloney commented Aug 11, 2016

thanks @lrvan for the contribution, I had a couple of questions (commented) about the method names and approach.

@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney

tonybaloney Sep 30, 2016

Contributor

Great. thanks 👍

Contributor

tonybaloney commented Sep 30, 2016

Great. thanks 👍

@asfgit asfgit closed this in 6d6fe47 Sep 30, 2016

asfgit pushed a commit that referenced this pull request Sep 30, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment