Create volume is more robust on newer OpenStacks #857
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sorry assertNotIn was only added in py2.7, you'll have to use |
allardhoeve
force-pushed
the
create_volume_is_more_robust
branch
from
42d069e to
db95261
Compare
|
Yeah, forgot about that ancient version ;) Changed it. |
allardhoeve
force-pushed
the
create_volume_is_more_robust
branch
from
db95261 to
6edf269
Compare
|
Thumbs up, anyone? |
|
lgtm |
|
Changes look good. thanks @allardhoeve +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make create_volume more robust on newer OpenStacks
Description
On newer OpenStacks, things will fail if you do not provide
locationor if you do not provideex_volume_type. The driver will pass the defaultNonevalues toself.driver.request, which serializes them tonull, which is an invalid value for/os-volumes/on newer incarnations of OpenStack.This PR makes it so the OpenStack driver does not include these fields if they are None, so they are not refused by OpenStack's validation.
Status
Checklist (tick everything that applies)