Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backup bug fix #858

Closed
wants to merge 6 commits into from
Closed

Backup bug fix #858

wants to merge 6 commits into from

Conversation

@relaxdiego
Copy link
Contributor

relaxdiego commented Sep 16, 2016

Description

This replaces PR #781.

Currently if a backup doesn't exists on a target, we return None, since we're using this value in getting a backup target we end up throwing an error
Also after linting, it looks like paginated responses were erroring out if paginated responses were empty.

Status

ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)
@relaxdiego relaxdiego force-pushed the relaxdiego:backup_bug_fix branch from 9918754 to 7fed326 Sep 18, 2016
@relaxdiego
Copy link
Contributor Author

relaxdiego commented Sep 18, 2016

The error from https://travis-ci.org/apache/libcloud/jobs/160522709 seems to be a flaky installation error whereas the error from https://travis-ci.org/apache/libcloud/jobs/160522727:

pylint runtests: commands[0] | pylint -E --rcfile=./.pylintrc libcloud/common/
************* Module libcloud.common.dimensiondata
E:489,18: Instance of 'unicode' has no 'get' member (no-member)
E:490,20: Instance of 'unicode' has no 'get' member (no-member)
E:491,39: Instance of 'unicode' has no 'get' member (no-member)

Appears to be a pylint error. The variable being referred to is an Element, not a unicode, object:

-> yield paged_resp
(Pdb) paged_resp
<Element '{urn:didata.com:api:cloud:types}servers' at 0x1100a7a90>

Compare the last commit's build with the build I ran against my fork and notice that only the pylint error shows up: https://travis-ci.org/relaxdiego/libcloud/builds/160750260

@tonybaloney
Copy link
Contributor

tonybaloney commented Sep 20, 2016

fixed build in downstream PR, waiting for @relaxdiego to merge into this PR.

@asfgit asfgit closed this in 62955e3 Sep 20, 2016
asfgit pushed a commit that referenced this pull request Sep 20, 2016
asfgit pushed a commit that referenced this pull request Jan 29, 2018
Unfortunately I can only do this by committing.

Closes #931 that is not useful and cannot be maintained.
Closes #845 which has been merged.
Closes #781 which was superseded by #858.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.