Backup bug fix #858

Closed
wants to merge 6 commits into
from

Conversation

Projects
None yet
3 participants
@relaxdiego
Contributor

relaxdiego commented Sep 16, 2016

Description

This replaces PR #781.

Currently if a backup doesn't exists on a target, we return None, since we're using this value in getting a backup target we end up throwing an error
Also after linting, it looks like paginated responses were erroring out if paginated responses were empty.

Status

ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)
@relaxdiego

This comment has been minimized.

Show comment
Hide comment
@relaxdiego

relaxdiego Sep 18, 2016

Contributor

The error from https://travis-ci.org/apache/libcloud/jobs/160522709 seems to be a flaky installation error whereas the error from https://travis-ci.org/apache/libcloud/jobs/160522727:

pylint runtests: commands[0] | pylint -E --rcfile=./.pylintrc libcloud/common/
************* Module libcloud.common.dimensiondata
E:489,18: Instance of 'unicode' has no 'get' member (no-member)
E:490,20: Instance of 'unicode' has no 'get' member (no-member)
E:491,39: Instance of 'unicode' has no 'get' member (no-member)

Appears to be a pylint error. The variable being referred to is an Element, not a unicode, object:

-> yield paged_resp
(Pdb) paged_resp
<Element '{urn:didata.com:api:cloud:types}servers' at 0x1100a7a90>

Compare the last commit's build with the build I ran against my fork and notice that only the pylint error shows up: https://travis-ci.org/relaxdiego/libcloud/builds/160750260

Contributor

relaxdiego commented Sep 18, 2016

The error from https://travis-ci.org/apache/libcloud/jobs/160522709 seems to be a flaky installation error whereas the error from https://travis-ci.org/apache/libcloud/jobs/160522727:

pylint runtests: commands[0] | pylint -E --rcfile=./.pylintrc libcloud/common/
************* Module libcloud.common.dimensiondata
E:489,18: Instance of 'unicode' has no 'get' member (no-member)
E:490,20: Instance of 'unicode' has no 'get' member (no-member)
E:491,39: Instance of 'unicode' has no 'get' member (no-member)

Appears to be a pylint error. The variable being referred to is an Element, not a unicode, object:

-> yield paged_resp
(Pdb) paged_resp
<Element '{urn:didata.com:api:cloud:types}servers' at 0x1100a7a90>

Compare the last commit's build with the build I ran against my fork and notice that only the pylint error shows up: https://travis-ci.org/relaxdiego/libcloud/builds/160750260

@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney

tonybaloney Sep 20, 2016

Contributor

fixed build in downstream PR, waiting for @relaxdiego to merge into this PR.

Contributor

tonybaloney commented Sep 20, 2016

fixed build in downstream PR, waiting for @relaxdiego to merge into this PR.

@asfgit asfgit closed this in 62955e3 Sep 20, 2016

asfgit pushed a commit that referenced this pull request Sep 20, 2016

@jr2730 jr2730 referenced this pull request in ansible/ansible-modules-extras Sep 22, 2016

Closed

New dimensiondata backup #3012

@tintoy tintoy referenced this pull request in ansible/ansible Dec 14, 2016

Merged

New dimensiondata network #19325

@tintoy tintoy referenced this pull request in ansible/ansible Jan 16, 2017

Closed

New dimensiondata vlan #20321

@tintoy tintoy referenced this pull request in ansible/ansible Jan 23, 2017

Closed

New dimensiondata firewall #20583

asfgit pushed a commit that referenced this pull request Jan 29, 2018

Cleanup pull request list
Unfortunately I can only do this by committing.

Closes #931 that is not useful and cannot be maintained.
Closes #845 which has been merged.
Closes #781 which was superseded by #858.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment