Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StorageVolumeSnapshot now has a .name #867

Closed
wants to merge 2 commits into from

Conversation

@allardhoeve
Copy link
Contributor

allardhoeve commented Sep 23, 2016

StorageVolumeSnapshot now has an attribute .name

Description

StorageVolumeSnapshot is the last object that normally has a name, that does not actually have an attribute .name. This PR adds that attribute. It leaves the .extra['name'] though, for backwards-compatibility.

Status

  • done, ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)
@allardhoeve allardhoeve force-pushed the ByteInternet:snapshot-has-name branch 2 times, most recently from 91ae8b3 to 89f3b0d Sep 23, 2016
allardhoeve added 2 commits Sep 23, 2016
@tonybaloney
Copy link
Contributor

tonybaloney commented Sep 30, 2016

👍 Thanks Allard

@asfgit asfgit closed this in b93d005 Sep 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.