StorageVolumeSnapshot now has a .name #867
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allardhoeve
force-pushed
the
snapshot-has-name
branch
2 times, most recently
from
91ae8b3 to
89f3b0d
Compare
|
👍 Thanks Allard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StorageVolumeSnapshot now has an attribute .name
Description
StorageVolumeSnapshot is the last object that normally has a name, that does not actually have an attribute
.name. This PR adds that attribute. It leaves the.extra['name']though, for backwards-compatibility.Status
Checklist (tick everything that applies)