New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DigitalOcean v1 driver as it has reached EOL. #889

Closed
wants to merge 2 commits into
base: trunk
from

Conversation

Projects
None yet
2 participants
@andrewsomething
Contributor

andrewsomething commented Oct 5, 2016

Remove DigitalOcean v1 driver as it has reached EOL.

Description

DigitalOcean API v1 reached EOL November 9, 2015. It's code paths can/should be removed.

https://developers.digitalocean.com/documentation/changelog/api-v1/sunsetting-api-v1/

Status

WIP: I still need to clean up the docs, but want to make sure that this is on the right track.

Checklist (tick everything that applies)

  • Code linting
  • Documentation
  • Tests
  • ICLA (Doubt I need this for removing code. I might have signed this before, but I'm not sure.)
@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney

tonybaloney Oct 5, 2016

Contributor

thanks @andrewsomething for the contribution. I was just looking through the change. we have an error that get raised when you run get_driver on a provider which no longer exists:
https://github.com/apache/libcloud/blob/trunk/libcloud/compute/deprecated.py and https://github.com/apache/libcloud/blob/trunk/libcloud/common/providers.py

Since this is just for deprecating the old API, that doesn't make sense but it would be good to have the errors more aligned. Please can you review the existing deprecated driver code and adjust this message (we include a URL for example).

Contributor

tonybaloney commented Oct 5, 2016

thanks @andrewsomething for the contribution. I was just looking through the change. we have an error that get raised when you run get_driver on a provider which no longer exists:
https://github.com/apache/libcloud/blob/trunk/libcloud/compute/deprecated.py and https://github.com/apache/libcloud/blob/trunk/libcloud/common/providers.py

Since this is just for deprecating the old API, that doesn't make sense but it would be good to have the errors more aligned. Please can you review the existing deprecated driver code and adjust this message (we include a URL for example).

@andrewsomething

This comment has been minimized.

Show comment
Hide comment
@andrewsomething

andrewsomething Oct 5, 2016

Contributor

@tonybaloney How's that look?

Contributor

andrewsomething commented Oct 5, 2016

@tonybaloney How's that look?

@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney

tonybaloney Oct 5, 2016

Contributor

@andrewsomething great. I'll make sure this is in the release notes for the next release, scheduled next couple of weeks.

Contributor

tonybaloney commented Oct 5, 2016

@andrewsomething great. I'll make sure this is in the release notes for the next release, scheduled next couple of weeks.

@asfgit asfgit closed this in 2a08928 Oct 5, 2016

@andrewsomething andrewsomething deleted the andrewsomething:LIBCLOUD-857_Remove_DO_APIv1 branch Oct 6, 2016

@andrewsomething andrewsomething restored the andrewsomething:LIBCLOUD-857_Remove_DO_APIv1 branch Oct 6, 2016

asfgit pushed a commit that referenced this pull request Oct 6, 2016

asfgit pushed a commit that referenced this pull request Oct 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment