Remove DigitalOcean v1 driver as it has reached EOL.#889
Closed
andrewsomething wants to merge 2 commits intoapache:trunkfrom
Closed
Remove DigitalOcean v1 driver as it has reached EOL.#889andrewsomething wants to merge 2 commits intoapache:trunkfrom
andrewsomething wants to merge 2 commits intoapache:trunkfrom
Conversation
Contributor
|
thanks @andrewsomething for the contribution. I was just looking through the change. we have an error that get raised when you run get_driver on a provider which no longer exists: Since this is just for deprecating the old API, that doesn't make sense but it would be good to have the errors more aligned. Please can you review the existing deprecated driver code and adjust this message (we include a URL for example). |
Contributor
Author
|
@tonybaloney How's that look? |
Contributor
|
@andrewsomething great. I'll make sure this is in the release notes for the next release, scheduled next couple of weeks. |
1 task
asfgit
pushed a commit
that referenced
this pull request
Oct 6, 2016
asfgit
pushed a commit
that referenced
this pull request
Oct 11, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove DigitalOcean v1 driver as it has reached EOL.
Description
DigitalOcean API v1 reached EOL November 9, 2015. It's code paths can/should be removed.
https://developers.digitalocean.com/documentation/changelog/api-v1/sunsetting-api-v1/
Status
WIP: I still need to clean up the docs, but want to make sure that this is on the right track.
Checklist (tick everything that applies)