New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new FCU API support in Outscale EC2 driver #890

Closed
wants to merge 11 commits into
base: trunk
from

Conversation

Projects
None yet
2 participants
@jmunhoz
Contributor

jmunhoz commented Oct 5, 2016

Add libcloud support for the following new APIs available in the Flexible Computing Unit (FCU)

  • DescribeInstanceTypes
  • DescribeProductTypes
  • GetProductType
  • DescribeQuota
  • ModifyInstanceKeypair

The patchset includes tests and fixtures for the new APIs.

Signed-off-by: Javier M. Mellid jmunhoz@igalia.com

jmunhoz added some commits Oct 3, 2016

Add Outscale API constants working with TINA OS
Update version and namespace matching the current TINA OS API (AWS EC2
compatible)

This patch handle two different versions between the API version used to issue
requests and the API version crafted in the namespace. It is a bug in the
server side currently. The bugfix is work in progress. Meanwhile we need those
bits in place to keep the new APIs working.

Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>
Add new DescribeQuota API in Outscale EC2 driver
Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>
Add new DescribeProductTypes API in Outscale EC2 driver
Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>
Add new DescribeInstanceTypes API in Outscale EC2 driver
Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>
Add new GetProductType API in Outscale EC2 driver
Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>
Add new ModifyInstanceKeypair API in Outscale EC2 driver
Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>
Add tests and fixtures FCU DescribeQuota API
Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>
Add tests and fixtures FCU DescribeProductTypes API
Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>
Add tests and fixtures FCU DescribeInstanceTypes API
Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>
Add tests and fixtures FCU GetProductType API
Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>
Add tests and fixtures FCU ModifyInstanceKeypair API
Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>
@tonybaloney

Great thanks @jmunhoz for the updates.

if filters:
raise NotImplementedError(
'quota filters are not implemented')

This comment has been minimized.

@tonybaloney

tonybaloney Oct 5, 2016

Contributor

when will this be implemented?

@tonybaloney

tonybaloney Oct 5, 2016

Contributor

when will this be implemented?

This comment has been minimized.

@jmunhoz

jmunhoz Oct 6, 2016

Contributor

@tonybaloney thanks for reviewing. we hope a new release of FCU at the end of November or December. Filters in this API are being reworked cause the original implementation is raising some non expected issues in the server side and we had to rollback although the API doc was published and the interface spec is stable. This way users get a clear message and they would not report this well-know bug.

BTW this first patchset would be also a first update to catch up with the new features and improvements in the FCU. Outscale would like to contribute new APIs and available features implemented along the previous months in the server side. As expected, with each new FCU release we would revisit the non implemented bits and bugfixes to support the new features as soon as they hit production in the server side.

@jmunhoz

jmunhoz Oct 6, 2016

Contributor

@tonybaloney thanks for reviewing. we hope a new release of FCU at the end of November or December. Filters in this API are being reworked cause the original implementation is raising some non expected issues in the server side and we had to rollback although the API doc was published and the interface spec is stable. This way users get a clear message and they would not report this well-know bug.

BTW this first patchset would be also a first update to catch up with the new features and improvements in the FCU. Outscale would like to contribute new APIs and available features implemented along the previous months in the server side. As expected, with each new FCU release we would revisit the non implemented bits and bugfixes to support the new features as soon as they hit production in the server side.

@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney

tonybaloney Oct 7, 2016

Contributor

Ok. I'm happy 👍

Contributor

tonybaloney commented Oct 7, 2016

Ok. I'm happy 👍

@asfgit asfgit closed this in 4fb3bc3 Oct 7, 2016

asfgit pushed a commit that referenced this pull request Oct 7, 2016

@jmunhoz

This comment has been minimized.

Show comment
Hide comment
@jmunhoz

jmunhoz Oct 7, 2016

Contributor

@tonybaloney thanks! 👍

Contributor

jmunhoz commented Oct 7, 2016

@tonybaloney thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment