Conversation
tonybaloney
left a comment
tonybaloney
left a comment
There was a problem hiding this comment.
Thanks very much @ZuluPro I've made some comments but overall this PR is excellent.
| def get_timestamp(self): | ||
| if not self._timedelta: | ||
| url = 'https://%s/%s/auth/time' % (API_HOST, API_ROOT) | ||
| url = 'https://%s%s/auth/time' % (API_HOST, API_ROOT) |
There was a problem hiding this comment.
can you just clarify for me that it was intentional to drop / in between %s and %s
There was a problem hiding this comment.
Because API_ROOT already starts with '/' (https://github.com/apache/libcloud/pull/891/files/a5ed7e1f907cd1fcb5dde3f873bf4855012f3fe7#diff-b98d1474f4f20fc646a3ac82fcbd0387R37) . So it will make a doublet.
Maybe it worked with RunAbove, but not with OVH
libcloud/compute/drivers/ovh.py
Outdated
| def list_sizes(self, location=None): | ||
| action = API_ROOT + '/flavor' | ||
| data = {} | ||
| action = '%s/cloud/project/%s/flavor' % (API_ROOT, self.project_id) |
There was a problem hiding this comment.
You make this transformation a lot. I would either store this as an instance level attribute or have a private method for _request_for_project.
There was a problem hiding this comment.
I refactor code with _get_project_action.
| Provider.RUNABOVE: | ||
| ('libcloud.compute.drivers.runabove', 'RunAboveNodeDriver'), | ||
| Provider.OVH: | ||
| ('libcloud.compute.drivers.ovh', 'OvhNodeDriver'), |
There was a problem hiding this comment.
Provider.RUNABOVE should be added to the deprecated dictionary with a message about using the OVH service instead of RA so that when someone runs get_driver(Provider.RUNABOVE) they get a deprecated driver exception
There was a problem hiding this comment.
Done! Say me if I miss something!
|
@ZuluPro OK. good to merge. great work. thanks |
2 participants
Replace RunAbove driver by OVH
Description
RunAbove is the OVH's test platform. Now its compute is closed, I replaced by their final solution at OVH.
Status
Done
Checklist (tick everything that applies)