New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace RunAbove driver by OVH #891

Closed
wants to merge 4 commits into
base: trunk
from

Conversation

Projects
None yet
2 participants
@ZuluPro
Contributor

ZuluPro commented Oct 5, 2016

Replace RunAbove driver by OVH

Description

RunAbove is the OVH's test platform. Now its compute is closed, I replaced by their final solution at OVH.

Status

Done

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)
@tonybaloney

Thanks very much @ZuluPro I've made some comments but overall this PR is excellent.

@@ -115,17 +116,23 @@ def request_consumer_key(self, user_id):
def get_timestamp(self):
if not self._timedelta:
url = 'https://%s/%s/auth/time' % (API_HOST, API_ROOT)
url = 'https://%s%s/auth/time' % (API_HOST, API_ROOT)

This comment has been minimized.

@tonybaloney

tonybaloney Oct 5, 2016

Contributor

can you just clarify for me that it was intentional to drop / in between %s and %s

@tonybaloney

tonybaloney Oct 5, 2016

Contributor

can you just clarify for me that it was intentional to drop / in between %s and %s

This comment has been minimized.

@ZuluPro

ZuluPro Oct 6, 2016

Contributor

Because API_ROOT already starts with '/' (https://github.com/apache/libcloud/pull/891/files/a5ed7e1f907cd1fcb5dde3f873bf4855012f3fe7#diff-b98d1474f4f20fc646a3ac82fcbd0387R37) . So it will make a doublet.
Maybe it worked with RunAbove, but not with OVH

@ZuluPro

ZuluPro Oct 6, 2016

Contributor

Because API_ROOT already starts with '/' (https://github.com/apache/libcloud/pull/891/files/a5ed7e1f907cd1fcb5dde3f873bf4855012f3fe7#diff-b98d1474f4f20fc646a3ac82fcbd0387R37) . So it will make a doublet.
Maybe it worked with RunAbove, but not with OVH

Show outdated Hide outdated libcloud/compute/drivers/ovh.py
Provider.RUNABOVE:
('libcloud.compute.drivers.runabove', 'RunAboveNodeDriver'),
Provider.OVH:
('libcloud.compute.drivers.ovh', 'OvhNodeDriver'),

This comment has been minimized.

@tonybaloney

tonybaloney Oct 5, 2016

Contributor

Provider.RUNABOVE should be added to the deprecated dictionary with a message about using the OVH service instead of RA so that when someone runs get_driver(Provider.RUNABOVE) they get a deprecated driver exception

@tonybaloney

tonybaloney Oct 5, 2016

Contributor

Provider.RUNABOVE should be added to the deprecated dictionary with a message about using the OVH service instead of RA so that when someone runs get_driver(Provider.RUNABOVE) they get a deprecated driver exception

This comment has been minimized.

@ZuluPro

ZuluPro Oct 6, 2016

Contributor

Done! Say me if I miss something!

@ZuluPro

ZuluPro Oct 6, 2016

Contributor

Done! Say me if I miss something!

@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney

tonybaloney Oct 6, 2016

Contributor

@ZuluPro OK. good to merge. great work. thanks

Contributor

tonybaloney commented Oct 6, 2016

@ZuluPro OK. good to merge. great work. thanks

@asfgit asfgit closed this in cc9a013 Oct 6, 2016

asfgit pushed a commit that referenced this pull request Oct 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment