New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Feature - Edit Dimension Data Firewall Rule #893

Merged
merged 12 commits into from Oct 10, 2016

Conversation

Projects
None yet
3 participants
@samuelchong
Contributor

samuelchong commented Oct 7, 2016

Changes Title (replace this with a logical title for your changes)

Description

Implemented a new feature to DD libcloud to Edit Firewall Rule. This feature didn't exists before but it is now made available. Firewall rule will also accept portlist and ipaddresslist. Code snippet provided in the comment section of each method.

Status

  • done, ready for review

Checklist (tick everything that applies)

  • [Y] Code linting (required, can be done after the PR checks)
  • [Y] Documentation
  • [Y] Tests
  • ICLA (required for bigger changes)
@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney

tonybaloney Oct 7, 2016

Contributor

thanks @samuelchong the change you submitted doesn't work in Python 2.6, also there are some issues with the linter.

https://travis-ci.org/apache/libcloud/builds/165730443

Contributor

tonybaloney commented Oct 7, 2016

thanks @samuelchong the change you submitted doesn't work in Python 2.6, also there are some issues with the linter.

https://travis-ci.org/apache/libcloud/builds/165730443

Show outdated Hide outdated libcloud/test/compute/test_dimensiondata.py
end='190.2.2.108')
ip_address_3 = DimensionDataIpAddress(begin='190.2.2.0',
prefix_size='24')
ip_address_collection = {ip_address_1, ip_address_2,

This comment has been minimized.

@tonybaloney

tonybaloney Oct 7, 2016

Contributor

you can't build sets like this in Python 2.6. Did you mean this to be a set?

@tonybaloney

tonybaloney Oct 7, 2016

Contributor

you can't build sets like this in Python 2.6. Did you mean this to be a set?

This comment has been minimized.

@samuelchong

samuelchong Oct 9, 2016

Contributor

Meant to use square bracket for a list. Syntax has been fixed and verified in python 2.7. Thx for your comment.

@samuelchong

samuelchong Oct 9, 2016

Contributor

Meant to use square bracket for a list. Syntax has been fixed and verified in python 2.7. Thx for your comment.

Show outdated Hide outdated libcloud/common/dimensiondata.py
def __repr__(self):
return ('<DimensionDataNic: private_ip_v4=%s, vlan=%s,'
'network_adapter=%s>'
% (self.private_ip_v4, self.vlan, self.network_adapter))

This comment has been minimized.

@tonybaloney

tonybaloney Oct 7, 2016

Contributor

this should be self.network_adapter_name

@tonybaloney

tonybaloney Oct 7, 2016

Contributor

this should be self.network_adapter_name

This comment has been minimized.

@samuelchong

samuelchong Oct 9, 2016

Contributor

Fixed to use self.network_adapter_name . Thx @tonybaloney

@samuelchong

samuelchong Oct 9, 2016

Contributor

Fixed to use self.network_adapter_name . Thx @tonybaloney

@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney

tonybaloney Oct 9, 2016

Contributor

thanks @samuelchong changes look good. 👍

Contributor

tonybaloney commented Oct 9, 2016

thanks @samuelchong changes look good. 👍

@asfgit asfgit merged commit 487e0b7 into apache:trunk Oct 10, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

asfgit pushed a commit that referenced this pull request Oct 10, 2016

@samuelchong samuelchong deleted the samuelchong:editfw branch Oct 10, 2016

@samuelchong

This comment has been minimized.

Show comment
Hide comment
@samuelchong

samuelchong Oct 10, 2016

Contributor

hooray. edit FW is merged into trunk.

Contributor

samuelchong commented Oct 10, 2016

hooray. edit FW is merged into trunk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment