Refactor DimensionData Create node to support MCP2 and backward compatible with MCP1 #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonybaloney
reviewed
Oct 20, 2016
| @@ -732,7 +732,8 @@ class DimensionDataServerDisk(object): | |||
| """ | |||
| A class that represents the disk on a server | |||
| """ | |||
| def __init__(self, id, scsi_id, size_gb, speed, state): | |||
| def __init__(self, id=None, scsi_id=None, size_gb=None, speed=None, | |||
There was a problem hiding this comment.
id should not be optional. I would also argue that none of the other variables should be either?
There was a problem hiding this comment.
Request for deploy server CaaS API https:///caas/2.3/{org-id}/server/deployServer is requiring scsi_id and speed only.
That's why I make them optional so that I could use this data class for deploy server.
<deployServer xmlns="urn:didata.com:api:cloud:types">
<name>Production FTPS Server</name>
<description>This is the main FTPS Server</description>
<imageId>e0b48a16-f5c3-4045-bfd0-a1a7232a2710</imageId>
<start>true</start>
<administratorPassword>P$$ssWwrrdGoDd!</administratorPassword>
<cpu speed="HIGHPERFORMANCE" count="4" coresPerSocket="2"/>
<memoryGb>4</memoryGb>
<network> <networkId>c550be0e-65c1-11e4-811f-005056806999</networkId>
</network>
<primaryDns>10.20.255.12</primaryDns>
<secondaryDns>10.20.255.13</secondaryDns>
<disk scsiId="0" speed="STANDARD"/>
<microsoftTimeZone>040</microsoftTimeZone>
</deployServer>
|
Ok. |
asfgit
pushed a commit
that referenced
this pull request
Oct 24, 2016
asfgit
pushed a commit
that referenced
this pull request
Oct 24, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Changes Title (replace this with a logical title for your changes)
Description
Refactor create_node for MCP2 to support CaaS API 2.3 feature. You could now specify Network Adapter Name for primary and additional NIC. Parameters in create_node function is tailored for MCP2.
However, this function also allow backward compatibility for MCP1 using kwargs. Code snippet provided in documentation on creating node for MCP1 and MCP2.
Status
Checklist (tick everything that applies)