Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upRefactor DimensionData Create node to support MCP2 and backward compatible with MCP1 #902
Conversation
samuelchong
added some commits
Oct 11, 2016
| @@ -732,7 +732,8 @@ class DimensionDataServerDisk(object): | ||
| """ | ||
| A class that represents the disk on a server | ||
| """ | ||
| def __init__(self, id, scsi_id, size_gb, speed, state): | ||
| def __init__(self, id=None, scsi_id=None, size_gb=None, speed=None, |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
tonybaloney
Oct 20, 2016
Contributor
id should not be optional. I would also argue that none of the other variables should be either?
tonybaloney
Oct 20, 2016
Contributor
id should not be optional. I would also argue that none of the other variables should be either?
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
samuelchong
Oct 20, 2016
Contributor
Request for deploy server CaaS API https:///caas/2.3/{org-id}/server/deployServer is requiring scsi_id and speed only.
That's why I make them optional so that I could use this data class for deploy server.
<deployServer xmlns="urn:didata.com:api:cloud:types">
<name>Production FTPS Server</name>
<description>This is the main FTPS Server</description>
<imageId>e0b48a16-f5c3-4045-bfd0-a1a7232a2710</imageId>
<start>true</start>
<administratorPassword>P$$ssWwrrdGoDd!</administratorPassword>
<cpu speed="HIGHPERFORMANCE" count="4" coresPerSocket="2"/>
<memoryGb>4</memoryGb>
<network> <networkId>c550be0e-65c1-11e4-811f-005056806999</networkId>
</network>
<primaryDns>10.20.255.12</primaryDns>
<secondaryDns>10.20.255.13</secondaryDns>
<disk scsiId="0" speed="STANDARD"/>
<microsoftTimeZone>040</microsoftTimeZone>
</deployServer>
samuelchong
Oct 20, 2016
•
edited
Edited 1 time
-
samuelchong
edited Oct 20, 2016 (most recent)
Contributor
edited
Edited 1 time
-
Oct 20, 2016 (most recent)
Request for deploy server CaaS API https:///caas/2.3/{org-id}/server/deployServer is requiring scsi_id and speed only.
That's why I make them optional so that I could use this data class for deploy server.
<deployServer xmlns="urn:didata.com:api:cloud:types">
<name>Production FTPS Server</name>
<description>This is the main FTPS Server</description>
<imageId>e0b48a16-f5c3-4045-bfd0-a1a7232a2710</imageId>
<start>true</start>
<administratorPassword>P$$ssWwrrdGoDd!</administratorPassword>
<cpu speed="HIGHPERFORMANCE" count="4" coresPerSocket="2"/>
<memoryGb>4</memoryGb>
<network> <networkId>c550be0e-65c1-11e4-811f-005056806999</networkId>
</network>
<primaryDns>10.20.255.12</primaryDns>
<secondaryDns>10.20.255.13</secondaryDns>
<disk scsiId="0" speed="STANDARD"/>
<microsoftTimeZone>040</microsoftTimeZone>
</deployServer>
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
Ok. |
asfgit
merged commit fc9c396
into
apache:trunk
Oct 24, 2016
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
pushed a commit
that referenced
this pull request
Oct 24, 2016
pushed a commit
that referenced
this pull request
Oct 24, 2016
samuelchong
deleted the
samuelchong:create_node_mcp2
branch
Oct 25, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
samuelchong commentedOct 13, 2016
Changes Title (replace this with a logical title for your changes)
Description
Refactor create_node for MCP2 to support CaaS API 2.3 feature. You could now specify Network Adapter Name for primary and additional NIC. Parameters in create_node function is tailored for MCP2.
However, this function also allow backward compatibility for MCP1 using kwargs. Code snippet provided in documentation on creating node for MCP1 and MCP2.
Status
Checklist (tick everything that applies)