New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIBCLOUD-867] Add st1 and sc1 volume types to valid types #925

Closed
wants to merge 1 commit into
base: trunk
from

Conversation

Projects
None yet
2 participants
@smgoller
Contributor

smgoller commented Oct 27, 2016

Add additional supported storage types to create_volume

Description

EC2 supports additional storage types geared toward throughput and cold storage. We have a need for the cold storage volume type but libcloud currently doesn't support it. It seemed a good idea to just put up a pull request for this instead of asking for the change since it's so small.

We didn't feel there was a need to create a test for this change, nor additional documentation examples. If this is not the case we can add them.

Status

  • done, ready for review

Checklist (tick everything that applies)

  • [*] Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)
@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney

tonybaloney Oct 30, 2016

Contributor

Seems simple enough, 👍 thanks for the PR.

Contributor

tonybaloney commented Oct 30, 2016

Seems simple enough, 👍 thanks for the PR.

@asfgit asfgit closed this in 41ff326 Oct 30, 2016

asfgit pushed a commit that referenced this pull request Oct 30, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment