New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the bug that created the node at ecs driver and implement the method for creating public ip #943

Closed
wants to merge 3 commits into
base: trunk
from

Conversation

Projects
None yet
3 participants
@watermelo

watermelo commented Nov 10, 2016

Changes Title (replace this with a logical title for your changes)

Description

1, From the official document can know parameter param['IoOptimized'] type is string and his value is none or optimized
Official document:
https://help.aliyun.com/document_detail/25499.html?spm=5176.doc25513.6.255.IAZjXA

2, Amend commit:
Implement the method for creating public ip.

Status

  • done, ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)
hequn
Fix the bug that created the node at ecs driver
1, From the official document can know parameter param['IoOptimized'] type is string and his value is ``none`` or ``optimized``
@watermelo

This comment has been minimized.

Show comment
Hide comment
@watermelo

watermelo Nov 11, 2016

Looks like there is a problem in unit test, I need to modify the unit test .

watermelo commented Nov 11, 2016

Looks like there is a problem in unit test, I need to modify the unit test .

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Nov 11, 2016

Member

Thanks!

The change looks good to me.

Member

Kami commented Nov 11, 2016

Thanks!

The change looks good to me.

@watermelo

This comment has been minimized.

Show comment
Hide comment
@watermelo

watermelo Nov 14, 2016

hi!~ @Kami , I have modified the unit test

watermelo commented Nov 14, 2016

hi!~ @Kami , I have modified the unit test

@watermelo watermelo changed the title from Fix the bug that created the node at ecs driver to Fix the bug that created the node at ecs driver and implement the method for creating public ip Nov 14, 2016

@watermelo

This comment has been minimized.

Show comment
Hide comment
@watermelo

watermelo Nov 14, 2016

Sorry, I'm not too familiar with github to cause no new branches to make a second commit. T.T

watermelo commented Nov 14, 2016

Sorry, I'm not too familiar with github to cause no new branches to make a second commit. T.T

@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney

tonybaloney Nov 14, 2016

Contributor

👍 thanks @watermelo

Contributor

tonybaloney commented Nov 14, 2016

👍 thanks @watermelo

@asfgit asfgit closed this in c726d1f Nov 14, 2016

asfgit pushed a commit that referenced this pull request Nov 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment