New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIBCLOUD-876] Added new AWS region to compute driver #946

Closed
wants to merge 2 commits into
base: trunk
from

Conversation

Projects
None yet
2 participants
@morissette

morissette commented Nov 15, 2016

Added us-east-2 region to AWS compute driver

Description

Added us-east-2 region to AWS as ec2_us_east_ohio based on how oregon region was handled in existing code base.

Status

  • done, ready for review

Checklist (tick everything that applies)

@morissette morissette changed the title from Added new AWS region to compute driver to [ LIBCLOUD-876 ] Added new AWS region to compute driver Nov 15, 2016

@morissette morissette changed the title from [ LIBCLOUD-876 ] Added new AWS region to compute driver to [LIBCLOUD-876] Added new AWS region to compute driver Nov 15, 2016

@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney

tonybaloney Nov 16, 2016

Contributor

build failure is nothing to do with this PR. 👍

Contributor

tonybaloney commented Nov 16, 2016

build failure is nothing to do with this PR. 👍

@asfgit asfgit closed this in 5182693 Nov 16, 2016

asfgit pushed a commit that referenced this pull request Nov 16, 2016

@morissette

This comment has been minimized.

Show comment
Hide comment
@morissette

morissette Nov 16, 2016

See the docs pulled but not the actual change.

On Tuesday, November 15, 2016, asfgit notifications@github.com wrote:

Closed #946 #946 via 5182693
5182693
.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#946 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADdgZxB80bGCzUPS0YbESUX89CBOseMEks5q-lJIgaJpZM4Ky-lc
.

morissette commented Nov 16, 2016

See the docs pulled but not the actual change.

On Tuesday, November 15, 2016, asfgit notifications@github.com wrote:

Closed #946 #946 via 5182693
5182693
.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#946 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADdgZxB80bGCzUPS0YbESUX89CBOseMEks5q-lJIgaJpZM4Ky-lc
.

@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney

tonybaloney Nov 16, 2016

Contributor

it gets a new hash when applied with git-am
8140f82
@morissette

Contributor

tonybaloney commented Nov 16, 2016

it gets a new hash when applied with git-am
8140f82
@morissette

@morissette

This comment has been minimized.

Show comment
Hide comment
@morissette

morissette Nov 16, 2016

Ahh awesome, havent used git-am before.

On Tuesday, November 15, 2016, Anthony Shaw notifications@github.com
wrote:

it gets a new hash when applied with git-am
8140f82
8140f82
@morissette https://github.com/morissette


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#946 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADdgZyn59l5dsA2loEtniC8DzgUoyMOfks5q-mZWgaJpZM4Ky-lc
.

morissette commented Nov 16, 2016

Ahh awesome, havent used git-am before.

On Tuesday, November 15, 2016, Anthony Shaw notifications@github.com
wrote:

it gets a new hash when applied with git-am
8140f82
8140f82
@morissette https://github.com/morissette


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#946 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADdgZyn59l5dsA2loEtniC8DzgUoyMOfks5q-mZWgaJpZM4Ky-lc
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment