New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to allow multiple node creation with subnets #949

Closed
wants to merge 3 commits into
base: trunk
from

Conversation

Projects
None yet
3 participants
@jbaublitz
Contributor

jbaublitz commented Nov 18, 2016

Add support for creating multiple nodes on a subnetwork

Description

NOTE: This is a reopen of PR #798 per the request of @supertom. I have rebased and reapplied the changes to current libcloud.

Currently for GCE, the multi node creation API does not support creating multiple nodes on a subnetwork. I have made changes to the ex_create_multiple_nodes function and the functions it calls to support creation of nodes on a given subnetwork. If subnetwork is None, the changes fall back to legacy network behavior on GCE so it is backwards compatible. There was one change to _create_node_req that was needed to get disk types which is simply passing in the location provided as an argument to ex_get_disktype.

Status

  • ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)
@supertom

This comment has been minimized.

Show comment
Hide comment
@supertom

supertom Nov 22, 2016

Contributor

@jbaublitz Thanks for the resubmission. I tested:

  • this PR directly, with both some code to create the VMs on a custom subnetwork
  • overall by running the gce_demo
  • ran tox to make sure everything looks good

LGTM!

/cc @erjohnso

Contributor

supertom commented Nov 22, 2016

@jbaublitz Thanks for the resubmission. I tested:

  • this PR directly, with both some code to create the VMs on a custom subnetwork
  • overall by running the gce_demo
  • ran tox to make sure everything looks good

LGTM!

/cc @erjohnso

@asfgit asfgit closed this in 0170630 Nov 22, 2016

@erjohnso

This comment has been minimized.

Show comment
Hide comment
@erjohnso

erjohnso Nov 22, 2016

Member

Thank you @jbaublitz - sorry for the confusion on your first attempt getting your change added!

Member

erjohnso commented Nov 22, 2016

Thank you @jbaublitz - sorry for the confusion on your first attempt getting your change added!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment