Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CaaS 2.4 features #953

Closed
wants to merge 34 commits into from
Closed

CaaS 2.4 features #953

wants to merge 34 commits into from

Conversation

@samuelchong
Copy link
Contributor

samuelchong commented Nov 25, 2016

Description

Support for CaaS API 2.4

  • import customer image
  • clone image (inc. NGOC)
  • Add feature exchange nic vlans
  • Add feature to Change NIC network adapter of a server

Status

Replace this: describe the PR status. Examples:

  • done, ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)
samuelchong added 30 commits Nov 3, 2016
…p workaround until Travis CI support Distutils.version with pylint
@tonybaloney
Copy link
Contributor

tonybaloney commented Nov 28, 2016

I assume you branched this from #940? We should close that first.

@tonybaloney
Copy link
Contributor

tonybaloney commented Nov 28, 2016

this now needs to be rebased, thanks Sam

@samuelchong
Copy link
Contributor Author

samuelchong commented Nov 30, 2016

Thx @tonybaloney. Rebase done.

@@ -483,7 +483,7 @@ def request_with_orgId_api_1(self, action, params=None, data='',
def request_with_orgId_api_2(self, action, params=None, data='',
headers=None, method='GET'):
action = "%s/%s" % (self.get_resource_path_api_2(), action)

print(action)

This comment has been minimized.

@tonybaloney

tonybaloney Dec 1, 2016 Contributor

please take this debug helper out


if len(tagkey_name_value_dictionaries) > 0:
for k, v in tagkey_name_value_dictionaries.items():
print(k, v)

This comment has been minimized.

@tonybaloney

tonybaloney Dec 1, 2016 Contributor

and this one

This comment has been minimized.

@samuelchong

samuelchong Dec 2, 2016 Author Contributor

thx @tonybaloney. Print line removed. What do you think about the idea building a debug mode feature to the framework?

@tonybaloney
Copy link
Contributor

tonybaloney commented Dec 2, 2016

👍 merging, thanks Sam

@asfgit asfgit closed this in a77e418 Dec 2, 2016
asfgit pushed a commit that referenced this pull request Dec 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.