-
Notifications
You must be signed in to change notification settings - Fork 922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CaaS 2.4 features #953
CaaS 2.4 features #953
Conversation
…p workaround until Travis CI support Distutils.version with pylint
Get changes for version compare
I assume you branched this from #940? We should close that first. |
this now needs to be rebased, thanks Sam |
Thx @tonybaloney. Rebase done. |
@@ -483,7 +483,7 @@ def request_with_orgId_api_1(self, action, params=None, data='', | |||
def request_with_orgId_api_2(self, action, params=None, data='', | |||
headers=None, method='GET'): | |||
action = "%s/%s" % (self.get_resource_path_api_2(), action) | |||
|
|||
print(action) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please take this debug helper out
|
||
if len(tagkey_name_value_dictionaries) > 0: | ||
for k, v in tagkey_name_value_dictionaries.items(): | ||
print(k, v) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx @tonybaloney. Print line removed. What do you think about the idea building a debug mode feature to the framework?
👍 merging, thanks Sam |
Description
Support for CaaS API 2.4
Status
Replace this: describe the PR status. Examples:
Checklist (tick everything that applies)