Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CaaS 2.4 features #953

Closed
wants to merge 34 commits into from
Closed

CaaS 2.4 features #953

wants to merge 34 commits into from

Conversation

samuelchong
Copy link
Contributor

Description

Support for CaaS API 2.4

  • import customer image
  • clone image (inc. NGOC)
  • Add feature exchange nic vlans
  • Add feature to Change NIC network adapter of a server

Status

Replace this: describe the PR status. Examples:

  • done, ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)

…p workaround until Travis CI support Distutils.version with pylint
@tonybaloney
Copy link
Contributor

I assume you branched this from #940? We should close that first.

@tonybaloney
Copy link
Contributor

this now needs to be rebased, thanks Sam

@samuelchong
Copy link
Contributor Author

Thx @tonybaloney. Rebase done.

@@ -483,7 +483,7 @@ def request_with_orgId_api_1(self, action, params=None, data='',
def request_with_orgId_api_2(self, action, params=None, data='',
headers=None, method='GET'):
action = "%s/%s" % (self.get_resource_path_api_2(), action)

print(action)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please take this debug helper out


if len(tagkey_name_value_dictionaries) > 0:
for k, v in tagkey_name_value_dictionaries.items():
print(k, v)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this one

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx @tonybaloney. Print line removed. What do you think about the idea building a debug mode feature to the framework?

@tonybaloney
Copy link
Contributor

👍 merging, thanks Sam

@asfgit asfgit closed this in a77e418 Dec 2, 2016
asfgit pushed a commit that referenced this pull request Dec 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants