Skip to content

Allow multiple preemptible instances to be created#954

Merged
asfgit merged 3 commits intoapache:trunkfrom
jbaublitz:ex_create_multiple_nodes_preempt
Apr 2, 2017
Merged

Allow multiple preemptible instances to be created#954
asfgit merged 3 commits intoapache:trunkfrom
jbaublitz:ex_create_multiple_nodes_preempt

Conversation

@jbaublitz
Copy link
Copy Markdown
Contributor

@jbaublitz jbaublitz commented Nov 28, 2016

Allow multiple preemptible instances to be created with ex_create_multiple_nodes

Description

This change enables multiple nodes to be created as preemptible on Google Cloud through the ex_create_multiple_nodes function call. Currently, this parameter is supported in the underlying functions in libcloud called by ex_create_multiple_nodes such as _create_node_req but the function itself does not expose this parameter at the top level. This patch enables a cluster of preemptible instances to be provisioned in parallel.

Status

  • ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)

\cc @supertom @erjohnso

@jbaublitz
Copy link
Copy Markdown
Contributor Author

@supertom This pull request is important for ansible now that ansible's gce module uses ex_create_multiple_nodes and provides the same parameters conditionally to both create_node and ex_create_multiple_nodes based on the number parameter. I recently tried to provision a cluster of preemptible nodes from ansible and libcloud notified me that ex_preemptible was not a supported parameter. I have tested the custom build of libcloud with this patch and it fixes the behavior I described in ansible in that use case.

@supertom
Copy link
Copy Markdown
Contributor

Thanks @jbaublitz! LGTM! @erjohnso, OK to merge.

asfgit pushed a commit that referenced this pull request Dec 27, 2016
@jbaublitz
Copy link
Copy Markdown
Contributor Author

Just for the sake of a breadcrumb trail, I'm going to link to the PR in ansible which will depend on the release including this PR to properly execute. ansible/ansible-modules-core#4276

@jbaublitz
Copy link
Copy Markdown
Contributor Author

@supertom @erjohnso Is there a status on merge date?

@tonybaloney
Copy link
Copy Markdown
Contributor

sorry @jbaublitz this got left a bit too long. merging.

@asfgit asfgit merged commit dbb20ce into apache:trunk Apr 2, 2017
asfgit pushed a commit that referenced this pull request Apr 2, 2017
asfgit pushed a commit that referenced this pull request Apr 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants