You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Allow multiple preemptible instances to be created with ex_create_multiple_nodes
Description
This change enables multiple nodes to be created as preemptible on Google Cloud through the ex_create_multiple_nodes function call. Currently, this parameter is supported in the underlying functions in libcloud called by ex_create_multiple_nodes such as _create_node_req but the function itself does not expose this parameter at the top level. This patch enables a cluster of preemptible instances to be provisioned in parallel.
Status
ready for review
Checklist (tick everything that applies)
Code linting (required, can be done after the PR checks)
@supertom This pull request is important for ansible now that ansible's gce module uses ex_create_multiple_nodes and provides the same parameters conditionally to both create_node and ex_create_multiple_nodes based on the number parameter. I recently tried to provision a cluster of preemptible nodes from ansible and libcloud notified me that ex_preemptible was not a supported parameter. I have tested the custom build of libcloud with this patch and it fixes the behavior I described in ansible in that use case.
Just for the sake of a breadcrumb trail, I'm going to link to the PR in ansible which will depend on the release including this PR to properly execute. ansible/ansible-modules-core#4276
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow multiple preemptible instances to be created with
ex_create_multiple_nodesDescription
This change enables multiple nodes to be created as preemptible on Google Cloud through the
ex_create_multiple_nodesfunction call. Currently, this parameter is supported in the underlying functions in libcloud called byex_create_multiple_nodessuch as_create_node_reqbut the function itself does not expose this parameter at the top level. This patch enables a cluster of preemptible instances to be provisioned in parallel.Status
Checklist (tick everything that applies)
\cc @supertom @erjohnso