Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIBCLOUD-880] Add a method for retrieving rates on Azure. #957

Closed

Conversation

@sorenisanerd
Copy link
Contributor

@sorenisanerd sorenisanerd commented Dec 11, 2016

Add a method for retrieving rates on Azure

Description

Azure has an API for retrieving rates. This patch exposes it.

Status

  • done, ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • [N/A] ICLA (required for bigger changes)
@supertom
Copy link
Contributor

@supertom supertom commented Dec 14, 2016

@sorenh I'm not an Azure user, but I did pull in this PR and then ran tox. LGTM. :-)

Loading

@tonybaloney
Copy link
Contributor

@tonybaloney tonybaloney commented Dec 27, 2016

cool. good idea casting to a set in the test ;0) merging

Loading

@asfgit asfgit closed this in 5263450 Dec 27, 2016
asfgit pushed a commit that referenced this issue Dec 27, 2016
@Kami
Copy link
Member

@Kami Kami commented Dec 27, 2016

@sorenh Btw, do you happen to be the same Soren who used to be the maintainer of the libcloud Ubuntu package (even before the Apache days and early Apache days if memory serves me right)?

If yes, thanks for that as well :)

Loading

@sorenisanerd
Copy link
Contributor Author

@sorenisanerd sorenisanerd commented Dec 29, 2016

@Kami Yes, that was me. :) You're very welcome. 👍

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants