New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Passing in Full API URL to Rancher Driver #958

Closed
wants to merge 1 commit into
base: trunk
from

Conversation

Projects
None yet
3 participants
@seglberg
Contributor

seglberg commented Dec 13, 2016

Rancher Driver: Allow Passing in Full API URL

Description

The scheme (secure) and port no longer need to be explicitly specified, allowing a user to simply copy in the string provided to them from Rancher.

Status

Done, ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)

Ping @InAnimaTe

Allow Passing in Full API URL to Rancher Driver
The scheme (secure) and port no longer need to be explicitly specified.
@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney

tonybaloney Dec 13, 2016

Contributor

Changes LGTM. @InAnimaTe ?

Contributor

tonybaloney commented Dec 13, 2016

Changes LGTM. @InAnimaTe ?

@InAnimaTe

This comment has been minimized.

Show comment
Hide comment
@InAnimaTe

InAnimaTe Dec 13, 2016

Contributor

LGTM!

Contributor

InAnimaTe commented Dec 13, 2016

LGTM!

@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney

tonybaloney Dec 27, 2016

Contributor

great. merging. ☃️

Contributor

tonybaloney commented Dec 27, 2016

great. merging. ☃️

@asfgit asfgit closed this in 88a5954 Dec 27, 2016

asfgit pushed a commit that referenced this pull request Dec 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment