Allow Passing in Full API URL to Rancher Driver#958
Closed
mmellison wants to merge 1 commit intoapache:trunkfrom
arroyonetworks:rancher-fixes
Closed
Allow Passing in Full API URL to Rancher Driver#958mmellison wants to merge 1 commit intoapache:trunkfrom arroyonetworks:rancher-fixes
mmellison wants to merge 1 commit intoapache:trunkfrom
arroyonetworks:rancher-fixes
Conversation
The scheme (secure) and port no longer need to be explicitly specified.
Contributor
|
Changes LGTM. @InAnimaTe ? |
Contributor
|
LGTM! |
Contributor
|
great. merging. ☃️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rancher Driver: Allow Passing in Full API URL
Description
The scheme (secure) and port no longer need to be explicitly specified, allowing a user to simply copy in the string provided to them from Rancher.
Status
Done, ready for review
Checklist (tick everything that applies)
Ping @InAnimaTe