New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenStackIdentity_2_0_Connection_VOMS class to manage auth with VOMS proxy files #959

Merged
merged 5 commits into from Dec 27, 2016

Conversation

Projects
None yet
4 participants
@micafer
Contributor

micafer commented Dec 14, 2016

Add OpenStackIdentity_2_0_Connection_VOMS class to manage auth with VOMS proxy files

Description

The class OpenStackIdentity_2_0_Connection_VOMS has been added to enable OpenStack driver to manage VOMS proxy files to get access to an OpenStack site.

https://keystone-voms.readthedocs.io/en/stable-mitaka/

Status

  • done, ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)
@supertom

This comment has been minimized.

Show comment
Hide comment
@supertom

supertom Dec 14, 2016

Contributor

@micafer I'm not an OpenStack libcloud user, but I merged this PR and ran tox, verifying that all tests, including the new test was successful. From that perspective, LGTM. :-)

Contributor

supertom commented Dec 14, 2016

@micafer I'm not an OpenStack libcloud user, but I merged this PR and ran tox, verifying that all tests, including the new test was successful. From that perspective, LGTM. :-)

@micafer micafer closed this Dec 16, 2016

@micafer micafer reopened this Dec 16, 2016

@micafer

This comment has been minimized.

Show comment
Hide comment
@micafer

micafer Dec 16, 2016

Contributor

It seems that some is failing in the tests, all are failing with this error:

E: Unable to locate package libvirt
apt-get install failed
Contributor

micafer commented Dec 16, 2016

It seems that some is failing in the tests, all are failing with this error:

E: Unable to locate package libvirt
apt-get install failed
@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney

tonybaloney Dec 27, 2016

Contributor

thanks @micafer. Merging.

Contributor

tonybaloney commented Dec 27, 2016

thanks @micafer. Merging.

@asfgit asfgit merged commit b55d9c6 into apache:trunk Dec 27, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

asfgit pushed a commit that referenced this pull request Dec 27, 2016

asfgit pushed a commit that referenced this pull request Dec 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment