Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upfix issue where port is not propagated down to connection URL #971
Conversation
|
mergey merge |
|
Good catch. |
| @@ -163,9 +163,10 @@ class LibcloudConnection(LibcloudBaseConnection): | |||
| response = None | |||
|
|
|||
| def __init__(self, host, port, **kwargs): | |||
| self.host = '{0}://{1}'.format( | |||
| self.host = '{0}://{1}{2}'.format( | |||
| 'https' if port == 443 else 'http', | |||
Kami
Jan 9, 2017
•
Member
Do we have access to secure argument here?
Because if we do, it looks like we still don't correctly handle one scenario - https on a non default port (protocol is not set correctly). For example, secure=True, port=8080 should result in https://<host>:8080.
Or am I missing something?
Do we have access to secure argument here?
Because if we do, it looks like we still don't correctly handle one scenario - https on a non default port (protocol is not set correctly). For example, secure=True, port=8080 should result in https://<host>:8080.
Or am I missing something?
Kami
Jan 9, 2017
Member
Edit: Sorry, I should have read the description better - you already addressed this scenario there.
Also checked the code and it looks like "secure" argument is not passed to the constructor right now so yeah, we would need to change some code to make it work.
Edit: Sorry, I should have read the description better - you already addressed this scenario there.
Also checked the code and it looks like "secure" argument is not passed to the constructor right now so yeah, we would need to change some code to make it work.
tonybaloney
Jan 9, 2017
Author
Contributor
@Kami yes, absolutely. That's a separate PR. I'm back to making one change at a time!
@Kami yes, absolutely. That's a separate PR. I'm back to making one change at a time!
Noticed that a custom port does not roll down properly to the connection class.
Also, there is still an outstanding issue that unless the port is 443, the connection will be assumed as plain HTTP.
E.g. setting port as 9999 but Secure=True will still issue a plain HTTP connection