Fix secure propagation to connection class

[tonybaloney]

Since there is no longer a secure/insecure connection class, they are one and the same.

This change adds new tests to check that

• When a connection is defined as secure, the connection class will use the https scheme.
• When a connection scheme implies a port, the port is not included in the URL
• When a connection defines secure and an unusual port, the scheme is propagated

It uncovered 1 issue with secure connections not being explicit for unusual ports.

[tonybaloney]

@Kami this is the second change to fix the issue you mentioned.

[tonybaloney]

merging

[allardhoeve]

I think the defaults would be more clear if this read:

def __init__(self, host, port, secure=None, **kwargs):
    if secure is None and port == 443:
        secure = True
    scheme = 'https' if secure else 'http'

    # ... rest of the code

I dislike inline logic because it is hard to find for the casual reader.

Also, a docstring would be nice.

[tonybaloney]

👍